You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/15 21:28:51 UTC

[GitHub] [flink] walterddr commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission

walterddr commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r347017067
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
 ##########
 @@ -509,7 +536,8 @@ static ContainerLaunchContext createTaskExecutorContext(
 					appId,
 					new Path(taskManagerConfigFile.toURI()),
 					homeDirPath,
-					"").f1;
+					"",
+					null).f1;
 
 Review comment:
   I think what @TisonKun means is if we use `setUpLocalResource()` and `registerPreloadedResource` as 2 different function. it is not needed to even pass in the null checker.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services