[GitHub] [hbase] Apache9 commented on a change in pull request #4136: HBASE-26245 Store region server list in master local region

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #4136:
URL: https://github.com/apache/hbase/pull/4136#discussion_r840176740



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -964,7 +969,8 @@ private void finishActiveMasterInitialization(MonitoredTask status) throws IOExc
     this.regionServerTracker.upgrade(
       procsByType.getOrDefault(ServerCrashProcedure.class, Collections.emptyList()).stream()
         .map(p -> (ServerCrashProcedure) p).map(p -> p.getServerName()).collect(Collectors.toSet()),
-      walManager.getLiveServersFromWALDir(), walManager.getSplittingServersFromWALDir());
+      Sets.union(rsListStorage.getAll(), walManager.getLiveServersFromWALDir()),

Review comment:
       Could be a follow up. It is not easy as the WAL directory is not actually a 'storage', so the 'migration' is not an actual migration as the WAL directory is always there even after 'migration'...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org