bad error message if commiting copied child of copied node

[Stefan Sperling <st...@elego.de>]

When I try to commit a copied child of a copied node, I get an
error like this:

  svn: E200009: '/tmp/svn-sandbox/trunk/epsilon2' is not under version
  control and is not part of the commit, yet its child
  '/tmp/svn-sandbox/trunk/epsilon2/zeta2' is part of the commit

Script below. This reproduces with trunk and 1.7.x.

I understand why the error is happening. It's not valid to try to
commit just children of a locally added or copied tree. The entire
tree has to be committed.

But "not under version control" is definitely not the right wording.
Any suggestions for what this should really be saying?

[[[
#!/bin/sh

set -e

cwd=`pwd`
basename=`basename $0`
scratch_area="`echo $basename | sed -e s/\.sh$//`"
repos=$scratch_area/repos
trunk=$scratch_area/trunk
branch=$scratch_area/branch
trunk_url=file:///$cwd/$repos/trunk
branch_url=file:///$cwd/$repos/branch

set -x

rm -rf $scratch_area
mkdir -p $scratch_area

mkdir -p $trunk
mkdir $trunk/epsilon
echo zeta > $trunk/epsilon/zeta

svnadmin create $cwd/$repos
svn import $trunk $trunk_url -m "importing project tree"
rm -rf $trunk
svn checkout $trunk_url $trunk

svn mv $trunk/epsilon $trunk/epsilon2
svn mv $trunk/epsilon2/zeta $trunk/epsilon2/zeta2
svn ci $trunk/epsilon2/zeta2 -m "try to commit zeta2"
]]]

RE: bad error message if commiting copied child of copied node

[Bert Huijben <be...@qqmail.nl>]

> -----Original Message-----
> From: Stefan Sperling [mailto:stsp@elego.de]
> Sent: vrijdag 29 juli 2011 1:29
> To: dev@subversion.apache.org
> Subject: bad error message if commiting copied child of copied node
> 
> When I try to commit a copied child of a copied node, I get an
> error like this:
> 
>   svn: E200009: '/tmp/svn-sandbox/trunk/epsilon2' is not under version
>   control and is not part of the commit, yet its child
>   '/tmp/svn-sandbox/trunk/epsilon2/zeta2' is part of the commit
> 
> Script below. This reproduces with trunk and 1.7.x.
> 
> I understand why the error is happening. It's not valid to try to
> commit just children of a locally added or copied tree. The entire
> tree has to be committed.
> 
> But "not under version control" is definitely not the right wording.
> Any suggestions for what this should really be saying?

This error message was written years ago (I assume pre 1.0) when "a not
committed node"/"an addition" was assumed not to be under version control
until it is committed.

Since then we added tracking of more and more local operations and we also
use files that are tracked locally as 'under version control'.

I think we should change the message to be more like our current messages,
but I can't say the original message is wrong.

	Bert