[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #2276: Core: Add option to combine tasks by partition

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r602731602



##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkReadOptions.java
##########
@@ -33,6 +33,9 @@ private SparkReadOptions() {
   // A timestamp in milliseconds; the snapshot used will be the snapshot current at this time.
   public static final String AS_OF_TIMESTAMP = "as-of-timestamp";
 
+  // Whether to combine splits by partition boundary or not.
+  public static final String BY_PARTITION = "by-partition";

Review comment:
       I think our common solution to this is to make a table property, I think in this use case it makes sense to have a table property and have a spark read option override for finer grained control




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org