You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/02 04:24:31 UTC

[GitHub] [pulsar] Jason918 opened a new pull request #12582: Fix log typo in NamespaceService#checkHeartbeatNamespace

Jason918 opened a new pull request #12582:
URL: https://github.com/apache/pulsar/pull/12582


   
   
   ### Motivation
   
   The log of `org.apache.pulsar.broker.namespace.NamespaceService#checkHeartbeatNamespace` and  `org.apache.pulsar.broker.namespace.NamespaceService#checkHeartbeatNamespaceV2` 
   have the same log line but not matching the method name, which is confusing.
   
   ### Modifications
   
   Changed the log content to match the method name.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: ( no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: ( no)
     - Anything that affects deployment: (no )
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [x] `no-need-doc` 
     
   Just fix typo
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #12582: Fix log typo in NamespaceService#checkHeartbeatNamespace

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #12582:
URL: https://github.com/apache/pulsar/pull/12582#issuecomment-957125141


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] github-actions[bot] commented on pull request #12582: Fix log typo in NamespaceService#checkHeartbeatNamespace

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12582:
URL: https://github.com/apache/pulsar/pull/12582#issuecomment-957091503


   @Jason918:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] github-actions[bot] commented on pull request #12582: Fix log typo in NamespaceService#checkHeartbeatNamespace

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12582:
URL: https://github.com/apache/pulsar/pull/12582#issuecomment-957091503


   @Jason918:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #12582: Fix log typo in NamespaceService#checkHeartbeatNamespace

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #12582:
URL: https://github.com/apache/pulsar/pull/12582#issuecomment-957125141


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] github-actions[bot] commented on pull request #12582: Fix log typo in NamespaceService#checkHeartbeatNamespace

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12582:
URL: https://github.com/apache/pulsar/pull/12582#issuecomment-957091503


   @Jason918:Thanks for providing doc info!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #12582: Fix log typo in NamespaceService#checkHeartbeatNamespace

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12582:
URL: https://github.com/apache/pulsar/pull/12582


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jason918 commented on pull request #12582: Fix log typo in NamespaceService#checkHeartbeatNamespace

Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #12582:
URL: https://github.com/apache/pulsar/pull/12582#issuecomment-957125141


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org