[jira] [Commented] (GIRAPH-299) Constant value in BspServiceMaster should be static

["Dionysios Logothetis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415813#comment-16415813 ] 

Dionysios Logothetis commented on GIRAPH-299:
---------------------------------------------

This field is not used any more.

> Constant value in BspServiceMaster should be static
> ---------------------------------------------------
>
>                 Key: GIRAPH-299
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-299
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 1.0.0
>            Reporter: Eli Reisman
>            Assignee: Dionysios Logothetis
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 1.0.0
>
>         Attachments: GIRAPH-299-2.patch, GIRAPH-299-3.patch, GIRAPH-299.patch
>
>
> GIRAPH-275 was a victim of this weekend's outage of the JIRA site. When I rebased the patch, I did it from a version that was not the last one I uploaded before said outage. 
> When I rebased the patch today, my most current version was not available to work from. So I forgot to perform the last fix it needed: to take the "localityLimit" constant on line 138 (used on line 536) of BspServiceMaster.java and make it static, and to change the name to LOCALITY_LIMIT to match proper convention.
> For those that already know how to create and upload a patch, please let this wait, its a perfect chance for someone new to submitting patches (and to Giraph) to test drive the process. Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)