You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gobblin.apache.org by ab...@apache.org on 2018/02/05 19:51:45 UTC
incubator-gobblin git commit: Don't let Helix retry when a child
process fails
Repository: incubator-gobblin
Updated Branches:
refs/heads/master 9e788351e -> 6cbc0cdd4
Don't let Helix retry when a child process fails
Closes #2258 from HappyRay/do-not-retry-when-
child-process-fails
Project: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/commit/6cbc0cdd
Tree: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/tree/6cbc0cdd
Diff: http://git-wip-us.apache.org/repos/asf/incubator-gobblin/diff/6cbc0cdd
Branch: refs/heads/master
Commit: 6cbc0cdd4e6e90f04a77f87ec77f454a7b5ac3ff
Parents: 9e78835
Author: Ray Yang <ru...@gmail.com>
Authored: Mon Feb 5 11:51:41 2018 -0800
Committer: Abhishek Tiwari <ab...@gmail.com>
Committed: Mon Feb 5 11:51:41 2018 -0800
----------------------------------------------------------------------
.../src/main/java/org/apache/gobblin/cluster/SingleHelixTask.java | 2 +-
.../test/java/org/apache/gobblin/cluster/SingleHelixTaskTest.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/6cbc0cdd/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleHelixTask.java
----------------------------------------------------------------------
diff --git a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleHelixTask.java b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleHelixTask.java
index 8a49f76..d10792d 100644
--- a/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleHelixTask.java
+++ b/gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleHelixTask.java
@@ -66,7 +66,7 @@ public class SingleHelixTask implements Task {
} else {
logger.warn("Task process failed with exitcode ({}). job name: {}. job id: {}", exitCode,
this.jobName, this.jobId);
- return new TaskResult(TaskResult.Status.FAILED, "Exit code: " + exitCode);
+ return new TaskResult(TaskResult.Status.FATAL_FAILED, "Exit code: " + exitCode);
}
} catch (final Throwable t) {
logger.error("SingleHelixTask failed due to " + t.getMessage(), t);
http://git-wip-us.apache.org/repos/asf/incubator-gobblin/blob/6cbc0cdd/gobblin-cluster/src/test/java/org/apache/gobblin/cluster/SingleHelixTaskTest.java
----------------------------------------------------------------------
diff --git a/gobblin-cluster/src/test/java/org/apache/gobblin/cluster/SingleHelixTaskTest.java b/gobblin-cluster/src/test/java/org/apache/gobblin/cluster/SingleHelixTaskTest.java
index 2f07452..256ef22 100644
--- a/gobblin-cluster/src/test/java/org/apache/gobblin/cluster/SingleHelixTaskTest.java
+++ b/gobblin-cluster/src/test/java/org/apache/gobblin/cluster/SingleHelixTaskTest.java
@@ -66,7 +66,7 @@ public class SingleHelixTaskTest {
final TaskResult result = createAndRunTask();
- assertThat(result.getStatus()).isEqualTo(TaskResult.Status.FAILED);
+ assertThat(result.getStatus()).isEqualTo(TaskResult.Status.FATAL_FAILED);
}
@Test