You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/12/24 13:11:14 UTC
Review Request 41708: AMBARI-14492 Copy Ranger config files to Ranger
conf directory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41708/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: AMBARI-14492
https://issues.apache.org/jira/browse/AMBARI-14492
Repository: ambari
Description
-------
Check if Ranger config files exists in Ranger Conf directory and if files are not available, copy them from conf.dist directory.
List of files
ranger-admin-default-site.xml
security-applicationContext.xml
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 39fad24
Diff: https://reviews.apache.org/r/41708/diff/
Testing
-------
Tested Ranger installation through wizard and blueprint on ubuntu 14 with HDP-2.4
----------------------------------------------------------------------
Ran 271 tests in 6.361s
OK
----------------------------------------------------------------------
Total run:890
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 41708: AMBARI-14492 Copy Ranger config files to
Ranger conf directory
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41708/#review111958
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On Dec. 28, 2015, 4:37 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41708/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 4:37 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14492
> https://issues.apache.org/jira/browse/AMBARI-14492
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Check if Ranger config files exists in Ranger Conf directory and if files are not available, copy them from conf.dist directory.
>
> List of files
> ranger-admin-default-site.xml
> security-applicationContext.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 39fad24
>
> Diff: https://reviews.apache.org/r/41708/diff/
>
>
> Testing
> -------
>
> Tested Ranger installation through wizard and blueprint on ubuntu 14 with HDP-2.4
>
> ----------------------------------------------------------------------
> Ran 271 tests in 6.361s
>
> OK
> ----------------------------------------------------------------------
> Total run:890
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 41708: AMBARI-14492 Copy Ranger config files to
Ranger conf directory
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41708/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 4:37 a.m.)
Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Address Sumit's comments
Bugs: AMBARI-14492
https://issues.apache.org/jira/browse/AMBARI-14492
Repository: ambari
Description
-------
Check if Ranger config files exists in Ranger Conf directory and if files are not available, copy them from conf.dist directory.
List of files
ranger-admin-default-site.xml
security-applicationContext.xml
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 39fad24
Diff: https://reviews.apache.org/r/41708/diff/
Testing
-------
Tested Ranger installation through wizard and blueprint on ubuntu 14 with HDP-2.4
----------------------------------------------------------------------
Ran 271 tests in 6.361s
OK
----------------------------------------------------------------------
Total run:890
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 41708: AMBARI-14492 Copy Ranger config files to
Ranger conf directory
Posted by Gautam Borad <gb...@gmail.com>.
> On Dec. 28, 2015, 4:21 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py, line 107
> > <https://reviews.apache.org/r/41708/diff/1/?file=1176088#file1176088line107>
> >
> > Why won't the files exist?
In most cases the file will be present, but in case if there is an issue in the rpm/deb packaging this will act as a fallback and prevent the RANGER service from failure to start.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41708/#review111955
-----------------------------------------------------------
On Dec. 28, 2015, 4:37 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41708/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 4:37 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14492
> https://issues.apache.org/jira/browse/AMBARI-14492
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Check if Ranger config files exists in Ranger Conf directory and if files are not available, copy them from conf.dist directory.
>
> List of files
> ranger-admin-default-site.xml
> security-applicationContext.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 39fad24
>
> Diff: https://reviews.apache.org/r/41708/diff/
>
>
> Testing
> -------
>
> Tested Ranger installation through wizard and blueprint on ubuntu 14 with HDP-2.4
>
> ----------------------------------------------------------------------
> Ran 271 tests in 6.361s
>
> OK
> ----------------------------------------------------------------------
> Total run:890
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 41708: AMBARI-14492 Copy Ranger config files to
Ranger conf directory
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41708/#review111955
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py (line 107)
<https://reviews.apache.org/r/41708/#comment172254>
Why won't the files exist?
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py (line 108)
<https://reviews.apache.org/r/41708/#comment172253>
Should be a warning as it is being remedied.
- Sumit Mohanty
On Dec. 24, 2015, 12:11 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41708/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2015, 12:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14492
> https://issues.apache.org/jira/browse/AMBARI-14492
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Check if Ranger config files exists in Ranger Conf directory and if files are not available, copy them from conf.dist directory.
>
> List of files
> ranger-admin-default-site.xml
> security-applicationContext.xml
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 39fad24
>
> Diff: https://reviews.apache.org/r/41708/diff/
>
>
> Testing
> -------
>
> Tested Ranger installation through wizard and blueprint on ubuntu 14 with HDP-2.4
>
> ----------------------------------------------------------------------
> Ran 271 tests in 6.361s
>
> OK
> ----------------------------------------------------------------------
> Total run:890
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>