[GitHub] [iceberg] sudssf commented on a change in pull request #1221: ISSUE-1220: add option to disable manifest reading during estimateSta…

[GitBox <gi...@apache.org>]

sudssf commented on a change in pull request #1221:
URL: https://github.com/apache/iceberg/pull/1221#discussion_r457756127



##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -276,6 +280,9 @@ public void pruneColumns(StructType newRequestedSchema) {
 
   @Override
   public Statistics estimateStatistics() {
+    if(disableEstimateStatistics) {
+      return new Stats(Long.MAX_VALUE, Long.MAX_VALUE);
+    }

Review comment:
       thats really good idea, I thought about this too but I was under impression that we had to look data file metadata to get this information.
   I try to update PR using  total-records




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org