[GitHub] [incubator-pegasus] hycdong commented on a change in pull request #731: feat: add base classes for user-specified compaction

[GitBox <gi...@apache.org>]

hycdong commented on a change in pull request #731:
URL: https://github.com/apache/incubator-pegasus/pull/731#discussion_r641202536



##########
File path: src/server/compaction_filter_rule.h
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#pragma once
+
+#include <rocksdb/slice.h>
+
+namespace pegasus {
+namespace server {
+/** compaction_filter_rule represents the compaction rule to filter the keys which are stored in
+ * rocksdb. */
+class compaction_filter_rule
+{
+public:
+    virtual ~compaction_filter_rule() = default;
+
+    // TODO(zhaoliwei): we can use `value_filed` to replace existing_value in the later,
+    // after the refactor of value schema

Review comment:
       The refactor of value schema has already been merged, you can update it in next pull request :-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org