[GitHub] gianm commented on a change in pull request #6425: Emit emitter/buffers/allocated/delta and emitter/buffers/failed/delta

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6425: Emit emitter/buffers/allocated/delta and emitter/buffers/failed/delta
URL: https://github.com/apache/incubator-druid/pull/6425#discussion_r223500063
 
 

 ##########
 File path: java-util/src/main/java/org/apache/druid/java/util/metrics/HttpPostEmitterMonitor.java
 ##########
 @@ -81,6 +96,24 @@ private void emitTimeCounterMetrics(ServiceEmitter emitter, ConcurrentTimeCounte
     emitter.emit(builder.build(metricNameBase + "minTimeMs", timeCounter.getAndResetMinTime()));
   }
 
+  private void emitAllocatedBuffers(ServiceEmitter emitter)
+  {
+    int newTotalAllocatedBuffers = httpPostEmitter.getTotalAllocatedBuffers();
+    int allocatedBuffersDelta = newTotalAllocatedBuffers - lastTotalAllocatedBuffers;
+    emitter.emit(builder.build("emitter/buffers/allocated/total", newTotalAllocatedBuffers));
 
 Review comment:
   This isn't compatible with the old name `emitter/buffers/totalAllocated`, but I think it's ok because we never documented the old names anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org