[GitHub] [superset] mihir174 commented on issue #12631: [discuss]Should we remove the "+" icon for single metric control?

[GitBox <gi...@apache.org>]

mihir174 commented on issue #12631:
URL: https://github.com/apache/superset/issues/12631#issuecomment-768754233


   Hey everyone, this was a very interesting discussion. Here's my take:
   
   A big "plus" side to the button is that the control panel has a large vertical scroll surface, so having an "Add metric" CTA in the selected area will only make this taller and require more user scrolling. That being said, I agree that the button is unnecessary for input fields that take only 1 input.
   
   Given that we have received feedback from a couple of users, I think it's worth running some basic usability testing to compare different options before coming to a conclusion. If we are confident that users will prefer the proposed design change and if we think this issue is critical enough to address immediately, I will also +1 the change (bearing in mind the added vertical real estate). 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org