[GitHub] [fineract] vorburger commented on pull request #891: Logging checkstyle (Remove use of System.out)

[GitBox <gi...@apache.org>]

vorburger commented on pull request #891:
URL: https://github.com/apache/fineract/pull/891#issuecomment-629657412


   @thesmallstar this mostly LGTM now. Feedback:
   
   0. can you amend the commit message, and PR title/description, with the related JIRA, please?
   
   1. not sure what that's about, probably doesn't matter; let's ignore and move forward?
   
   2. can you chagne your IDE to avoid that in the future? But let's not redo this, but keep going. (The beautificating your IDE did behind your back appears to be related to max. line length? That is actually one of the Checkstyle modules... note `LineLength` - but let's get to that later, only; it has less priority (value) than e.g. the logging and exception handling related checks. But when we do get to that, we can discuss just exactly how long we want lines to be maximum. I think your IDE has it set to be too short; there's no need to break everything at 80 - the (right now still commented out) config currently has it at 120, but personally I'd probably even go for something bigger, like 160 or perhaps 140. We all have big screens nowadays! :smile: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org