You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Phillips <ap...@qrmedia.com> on 2014/08/05 23:41:08 UTC

Quick post-1.8.0 update

Some FYI items after 1.8.0...

CI setup changes:

* swapped PR bulider Java versions: "normal" runs 7, "-java-6" runs Java 6.
* added CI builds for 1.8.x
* switched the Java version for all the master builds to 7

Release doc done:

https://docs.google.com/document/d/10LkAD8Wk5Kcj38nQghTW-bQdCOXaxZad5W5Chu6HUCA

Release notes and Javadoc (thanks, Everett!) still in progress...

ap

Re: Quick post-1.8.0 update

Posted by Everett Toews <ev...@RACKSPACE.COM>.
Javadoc [1] is done and published, and links are included the release notes PR [2].

Everett

[1] http://jclouds.apache.org/reference/javadoc/1.8.x/
[2] https://github.com/jclouds/jclouds-site/pull/114


On Aug 5, 2014, at 4:41 PM, Andrew Phillips <ap...@qrmedia.com> wrote:

> Some FYI items after 1.8.0...
> 
> CI setup changes:
> 
> * swapped PR bulider Java versions: "normal" runs 7, "-java-6" runs Java 6.
> * added CI builds for 1.8.x
> * switched the Java version for all the master builds to 7
> 
> Release doc done:
> 
> https://docs.google.com/document/d/10LkAD8Wk5Kcj38nQghTW-bQdCOXaxZad5W5Chu6HUCA
> 
> Release notes and Javadoc (thanks, Everett!) still in progress...
> 
> ap


Re: Quick post-1.8.0 update

Posted by Andrew Phillips <ap...@qrmedia.com>.
> Sorry I do not understand -- you suggest pushing Java 7 commits to
> master and ignoring the error mails on every commit?  Would it make more
> sense to disable the Java 6 builder for all branches instead?

If we weren't still supporting Java 6 on 1.8.x I'd certainly agree.

As a compromise, how about disabling the *notification email* on the  
Java 6 builder instead?

ap

Re: Quick post-1.8.0 update

Posted by Andrew Phillips <ap...@qrmedia.com>.
> but I also see some suspicious bytecode version failures mails going  
> out over the general notifications list.

Some of these (e.g. [1]) were done to master builds that weren't  
properly updated to Java 7 - I've just fixed labs-aws, labs-google and  
labs-openstack.

Hopefully, that should get rid of "invalid target version" warning  
emails on notifications@. If anyone spots a suspicious email going by  
on that list, please ping!

ap

[1]  
http://mail-archives.apache.org/mod_mbox/jclouds-notifications/201408.mbox/%3C1429976525.40.1407614797883.JavaMail.jclouds%40jenkins-jclouds%3E

Re: Quick post-1.8.0 update

Posted by Andrew Phillips <ap...@qrmedia.com>.
> I object to the extra GitHub failure mails, but I also see some
> suspicious bytecode version failures mails going out over the general
> notifications list.

Let my see if I can find one of the "bytecode version failure" emails.  
The only thing I can imagine is a comment notification email when the  
Java 6 builder returns, but I'm curious to see what we come up with.

Could you forward me a copy of a "GitHub failure mail"? I'm not sure  
what you're referring to here.

In general, does anyone have an suggestions on how we can verify that  
PRs against 1.8.x work with Java 6 while verifying PRs against master  
using Java 7? Perhaps there's a nice pre-build step we could add to  
the Java 6 builder that would prevent the compilation failure?

ap

Re: Quick post-1.8.0 update

Posted by Andrew Phillips <ap...@qrmedia.com>.
Quick update on the PR builders: we now have a new Java 6 builder that  
uses a conditional build step to only run the Maven build if the  
target version is 1.6:

https://github.com/jclouds/jclouds/pull/482#issuecomment-52006177
https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/3/console

It's not an *ideal* solution because the build still runs, and  
success, rather than being skipped or not triggering at all. But the  
CloudBees folks say that's the best we're likely to be able to do at  
this point.

There's one small practical difference: the new builder does not  
support a per-module Checkstyle view, since it's a freestyle build.  
Compare

https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/violations/

with

https://jclouds.ci.cloudbees.com/job/PARKED-jclouds-java-6-pull-requests/violations/

I actually quite like the "new" style, but wanted to point this out  
before we delete the old PR builder. I was planning to do that at the  
end of the week if there are no concerns.

Regards

ap

Re: Quick post-1.8.0 update

Posted by Andrew Gaul <ga...@apache.org>.
On Sat, Aug 09, 2014 at 02:01:00PM +0200, Andrew Phillips wrote:
> >Sorry I do not understand -- you suggest pushing Java 7 commits to
> >master and ignoring the error mails on every commit?
> 
> PS: Which emails are you referring to here? The *commit* builder for
> master is on Java 7 only - there is no Java 6 builder for that.
> 
> The Java PR builder shouldn't be sending any emails (at any rate, I
> can't see any notifications configured for it in DEV@cloud) and
> should only be adding comments to the PR. The suggestion is to
> ignore those for PRs against master.

I object to the extra GitHub failure mails, but I also see some
suspicious bytecode version failures mails going out over the general
notifications list.

-- 
Andrew Gaul
http://gaul.org/

Re: Quick post-1.8.0 update

Posted by Andrew Phillips <ap...@qrmedia.com>.
> Sorry I do not understand -- you suggest pushing Java 7 commits to
> master and ignoring the error mails on every commit?

PS: Which emails are you referring to here? The *commit* builder for  
master is on Java 7 only - there is no Java 6 builder for that.

The Java PR builder shouldn't be sending any emails (at any rate, I  
can't see any notifications configured for it in DEV@cloud) and should  
only be adding comments to the PR. The suggestion is to ignore those  
for PRs against master.

ap

Re: Quick post-1.8.0 update

Posted by Andrew Gaul <ga...@apache.org>.
On Thu, Aug 07, 2014 at 08:37:23AM +0200, Andrew Phillips wrote:
> >How can we move forward with the Java 7 transition?  Do we need to
> >configure different builders?
> 
> The "jclouds-pull-request" builder is already on Java 7. We can just
> ignore the "jclouds-java-6-pull-request" builder for master, and
> look at it only for 1.8.x.

Sorry I do not understand -- you suggest pushing Java 7 commits to
master and ignoring the error mails on every commit?  Would it make more
sense to disable the Java 6 builder for all branches instead?

-- 
Andrew Gaul
http://gaul.org/

Re: Quick post-1.8.0 update

Posted by Andrew Phillips <ap...@qrmedia.com>.
> How can we move forward with the Java 7 transition?  Do we need to
> configure different builders?

The "jclouds-pull-request" builder is already on Java 7. We can just  
ignore the "jclouds-java-6-pull-request" builder for master, and look  
at it only for 1.8.x.

ap

Re: Quick post-1.8.0 update

Posted by Andrew Gaul <ga...@apache.org>.
On Wed, Aug 06, 2014 at 05:55:23PM +0200, Andrew Phillips wrote:
> >>Can you unhook the java-6 builder from master?  It still fails on my
> >>pull request:
> >
> >[...]
> >
> >I'll ask CloudBees...
> 
> ...and the answer is: no, that's currently not possible :-(

How can we move forward with the Java 7 transition?  Do we need to
configure different builders?

-- 
Andrew Gaul
http://gaul.org/

Re: Quick post-1.8.0 update

Posted by Andrew Phillips <ap...@qrmedia.com>.
>> Can you unhook the java-6 builder from master?  It still fails on my
>> pull request:
>
> [...]
>
> I'll ask CloudBees...

...and the answer is: no, that's currently not possible :-(

ap

Re: Quick post-1.8.0 update

Posted by Andrew Phillips <ap...@qrmedia.com>.
> Can you unhook the java-6 builder from master?  It still fails on my
> pull request:

I'm not quite sure how to do that :-( The builder triggers for PRs  
opened against *all* branches (e.g. [1]), and I don't know if it can  
be configured to ignore PRs against a specific branch.

I'll ask CloudBees...

ap

[1] https://github.com/jclouds/jclouds/pull/229

Re: Quick post-1.8.0 update

Posted by Andrew Gaul <ga...@apache.org>.
On Tue, Aug 05, 2014 at 11:41:08PM +0200, Andrew Phillips wrote:
> CI setup changes:
> 
> * swapped PR bulider Java versions: "normal" runs 7, "-java-6" runs Java 6.
> * added CI builds for 1.8.x
> * switched the Java version for all the master builds to 7

Can you unhook the java-6 builder from master?  It still fails on my
pull request:

https://github.com/jclouds/jclouds/pull/426

-- 
Andrew Gaul
http://gaul.org/