[jira] [Commented] (ARROW-1723) Windows: __declspec(dllexport) specified when building arrow static library

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217736#comment-16217736 ] 

ASF GitHub Bot commented on ARROW-1723:
---------------------------------------

JohnPJenkins opened a new pull request #1244: [ARROW-1723] add ARROW_STATIC to mark static libs on Windows
URL: https://github.com/apache/arrow/pull/1244
 
 
   Add a preprocessor macro ARROW_STATIC when doing static library builds on Windows. Clients developing/building off the static library will also need to define this - please let me know how this should be documented, if this is an acceptable approach.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Windows: __declspec(dllexport) specified when building arrow static library
> ---------------------------------------------------------------------------
>
>                 Key: ARROW-1723
>                 URL: https://issues.apache.org/jira/browse/ARROW-1723
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: John Jenkins
>              Labels: pull-request-available
>
> As I understand it, dllexport/dllimport should be left out when building and using static libraries on Windows. A PR will follow shortly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)