You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "abdilra7eem (via GitHub)" <gi...@apache.org> on 2024/07/14 10:54:50 UTC
[PR] l10n, ar, initial Arabic translation by Ali [superset]
abdilra7eem opened a new pull request, #29586:
URL: https://github.com/apache/superset/pull/29586
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(translations): Arabic translations [superset]
Posted by "OmarIthawi (via GitHub)" <gi...@apache.org>.
OmarIthawi commented on PR #29586:
URL: https://github.com/apache/superset/pull/29586#issuecomment-2268532474
Thanks @abdilra7eem.
Done @mistercrunch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(translations): Arabic translations [superset]
Posted by "OmarIthawi (via GitHub)" <gi...@apache.org>.
OmarIthawi commented on PR #29586:
URL: https://github.com/apache/superset/pull/29586#issuecomment-2266758469
Thanks @mistercrunch.
@abdilra7eem I think the conflicts happened due to https://github.com/apache/superset/pull/29782.
Would you mind rebasing and fixing those conflicts?
@mistercrunch will merge once you give us green-light.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(translations): Arabic translations [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #29586:
URL: https://github.com/apache/superset/pull/29586#issuecomment-2266264490
Somehow conflicting with something, happy to semi-blindly merge if/when conflicts are resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] l10n, ar, initial Arabic translation by Ali [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #29586:
URL: https://github.com/apache/superset/pull/29586#issuecomment-2231900389
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/29586?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 64.95%. Comparing base [(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`95d7810`)](https://app.codecov.io/gh/apache/superset/commit/95d7810af6bde7229d97053497e8f784fb3aa810?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 455 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #29586 +/- ##
==========================================
+ Coverage 60.48% 64.95% +4.46%
==========================================
Files 1931 524 -1407
Lines 76236 37781 -38455
Branches 8568 0 -8568
==========================================
- Hits 46114 24540 -21574
+ Misses 28017 13241 -14776
+ Partials 2105 0 -2105
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/29586/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/29586/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.12% <ø> (-0.04%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/29586/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/29586/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.70% <ø> (-0.11%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/29586/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.95% <ø> (+1.46%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/29586/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.85% <ø> (+2.22%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/29586?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(translations): Arabic translations [superset]
Posted by "OmarIthawi (via GitHub)" <gi...@apache.org>.
OmarIthawi commented on PR #29586:
URL: https://github.com/apache/superset/pull/29586#issuecomment-2280611178
@abdilra7eem would you mind following @mistercrunch instructions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(translations): Arabic translations [superset]
Posted by "OmarIthawi (via GitHub)" <gi...@apache.org>.
OmarIthawi commented on PR #29586:
URL: https://github.com/apache/superset/pull/29586#issuecomment-2254314899
@rusackas @michael-s-molina Thanks for triaging this pull request. This pull request is ready for review and merge.
Please enable the test run.
BTW, do we need to compile and add the Arabic frontend json file to git?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(translations): Arabic translations [superset]
Posted by "OmarIthawi (via GitHub)" <gi...@apache.org>.
OmarIthawi commented on PR #29586:
URL: https://github.com/apache/superset/pull/29586#issuecomment-2309507004
Thanks @abdilra7eem for the update. @mistercrunch it's now ready for merge. Could you please triage it before there are conflicts with master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(translations): Arabic translations [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #29586:
URL: https://github.com/apache/superset/pull/29586#issuecomment-2267158558
For easier merge you may want to run `./scripts/translations/babel_update.sh` prior to rebasing. Recently I added `--no-location` which should facilitate much easier merge as the `.po` files are now stripped of references which used to make merging/rebasing really difficult.
So
```
./scripts/translations/babel_update.sh
git pull --rebase {your_main_fork_remote} master
```
Hopefully things go smoothly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(translations): Arabic translations [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #29586:
URL: https://github.com/apache/superset/pull/29586#issuecomment-2274319141
Hey I pulled your branch and still see as though you didn't run the newer version of `./scripts/translations/babel_update.sh` which includes the `--no-location` flag. You can see it in your local branch it looks like this:
<img width="929" alt="Screenshot 2024-08-07 at 1 42 51 PM" src="https://github.com/user-attachments/assets/048e5439-f5da-4c98-ae97-d4b029919745">
But if you can run the **latest version** of `./scripts/translations/babel_update.sh`, there shouldn't be all these [purple in my screenshot] comments referencing where that msgid lives. See how these comments aren't there in the `master` branch of the file you are changing -> https://github.com/apache/superset/blob/master/superset/translations/ar/LC_MESSAGES/messages.po
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(translations): Arabic translations [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #29586:
URL: https://github.com/apache/superset/pull/29586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(translations): Arabic translations [superset]
Posted by "OmarIthawi (via GitHub)" <gi...@apache.org>.
OmarIthawi commented on PR #29586:
URL: https://github.com/apache/superset/pull/29586#issuecomment-2311775739
Thank you @mistercrunch and everyone for your review and help!
Congrats @abdilra7eem for your first contribution here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org