You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "mikelui (via GitHub)" <gi...@apache.org> on 2023/04/06 13:04:50 UTC

[GitHub] [arrow] mikelui opened a new issue, #34932: Should vendored libraries be in private namespaces?

mikelui opened a new issue, #34932:
URL: https://github.com/apache/arrow/issues/34932

   ### Describe the enhancement requested
   
   In #13775 flatbuffers was moved to a private namespace because it was causing ODR issues.
   
   I've seen the. same problems working with some of the vendored libraries: https://github.com/apache/arrow/tree/main/cpp/src/arrow/vendored
   
   I saw at least one of the libraries is already in an arrow_vendored namespace: https://github.com/apache/arrow/tree/main/cpp/src/arrow/vendored/fast_float
   
   I'm thinking all of the vendored libraries should be put in the `arrow_vendored` namespace. 
   
   Is there any reason this isn't done, or has it just not been on the radar?
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on issue #34932: [C++] Should all vendored libraries be in private namespaces?

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #34932:
URL: https://github.com/apache/arrow/issues/34932#issuecomment-1499873726

   Thanks!
   
   > But I won't be able to get to it for about another week.
   
   No problem!
   
   > Just wanted to check if there was any reason against it before looking into it more
   
   I like this approach. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] mikelui commented on issue #34932: [C++] Should all vendored libraries be in private namespaces?

Posted by "mikelui (via GitHub)" <gi...@apache.org>.
mikelui commented on issue #34932:
URL: https://github.com/apache/arrow/issues/34932#issuecomment-1499831258

   I can work on this, yes! But I won't be able to get to it for about another week. Just wanted to check if there was any reason against it before looking into it more, but doesn't sound that way :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on issue #34932: [C++] Should all vendored libraries be in private namespaces?

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #34932:
URL: https://github.com/apache/arrow/issues/34932#issuecomment-1499566774

   It makes sense.
   Do you want to work on this?
   
   It's better that we have scripts that automate this like `fast_float`: https://github.com/apache/arrow/blob/main/cpp/src/arrow/vendored/fast_float/update.sh


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on issue #34932: [C++] Should all vendored libraries be in private namespaces?

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #34932:
URL: https://github.com/apache/arrow/issues/34932#issuecomment-1499570872

   It's better that we have one issue/PR per one vendored library.
   (We can use this issue as an umbrella issue like #14542 .)
   
   One large PR is difficult to review...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org