You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2012/08/30 00:14:07 UTC

[jira] [Commented] (HBASE-6689) HRegion.increment comment nits

    [ https://issues.apache.org/jira/browse/HBASE-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444473#comment-13444473 ] 

stack commented on HBASE-6689:
------------------------------

+1 on patch
                
> HRegion.increment comment nits
> ------------------------------
>
>                 Key: HBASE-6689
>                 URL: https://issues.apache.org/jira/browse/HBASE-6689
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Trivial
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6689.patch
>
>
> Just a couple of trivial nits with the comments in this area of code:
> - In the test, a thread is called reader when it never actually reads, just flushes
> - The WAL edits are prepared per column family, then the WAL is written once all the column families have been checked.  But the comment says "// Append update to WAL" (as if it were being written) when the edits are just being prepared on a single column family.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira