You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/13 18:20:33 UTC

[GitHub] [kafka] franz1981 commented on pull request #12163: KAFKA-13900 Support Java 9 direct ByteBuffer Checksum methods

franz1981 commented on PR #12163:
URL: https://github.com/apache/kafka/pull/12163#issuecomment-1126318782

   I've put it in draft mode in order to better format it according to the community's rule, but feel free to review it: content-wise should be done.
   
   Some numbers, for JDK 11:
   ```
   Benchmark                 (bytes)  (direct)  (readonly)  (seed)   Mode  Cnt   Score   Error   Units
   Crc32CBenchamrk.checksum      128     false       false      42  thrpt   20  26.922 ± 0.065  ops/us
   Crc32CBenchamrk.checksum      128     false        true      42  thrpt   20   9.321 ± 0.031  ops/us
   Crc32CBenchamrk.checksum      128      true       false      42  thrpt   20  24.656 ± 0.620  ops/us
   Crc32CBenchamrk.checksum      128      true        true      42  thrpt   20  24.429 ± 0.668  ops/us
   Crc32CBenchamrk.checksum     1024     false       false      42  thrpt   20   6.548 ± 0.025  ops/us
   Crc32CBenchamrk.checksum     1024     false        true      42  thrpt   20   3.603 ± 0.087  ops/us
   Crc32CBenchamrk.checksum     1024      true       false      42  thrpt   20   6.432 ± 0.136  ops/us
   Crc32CBenchamrk.checksum     1024      true        true      42  thrpt   20   6.499 ± 0.042  ops/us
   Crc32CBenchamrk.checksum     4096     false       false      42  thrpt   20   4.031 ± 0.022  ops/us
   Crc32CBenchamrk.checksum     4096     false        true      42  thrpt   20   1.511 ± 0.009  ops/us
   Crc32CBenchamrk.checksum     4096      true       false      42  thrpt   20   4.004 ± 0.016  ops/us
   Crc32CBenchamrk.checksum     4096      true        true      42  thrpt   20   4.002 ± 0.020  ops/us
   ```
   The purpose of the PR is to makes heap and direct ByteBuffer able to perform the same (especially not read-only).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org