You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ameyjadiye <gi...@git.apache.org> on 2017/06/22 21:22:29 UTC
[GitHub] commons-text pull request #54: TEXT-93: RandomStringGenerator accepts a list...
GitHub user ameyjadiye opened a pull request:
https://github.com/apache/commons-text/pull/54
TEXT-93: RandomStringGenerator accepts a list of valid characters
Added selectFrom feature :
```
selectFromList(char[] chars)
selectFromList(List<Character> charList)
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ameyjadiye/commons-text TEXT-93
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-text/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit 278f1e0fb553fc2d2d6f5563d9e61899776cd80d
Author: Amey Jadiye <am...@gmail.com>
Date: 2017-06-22T21:18:11Z
TEXT-93: RandomStringGenerator accepts a list of valid characters
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #54: TEXT-93: RandomStringGenerator accepts a list of val...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/54
[](https://:/builds/12097991)
Coverage decreased (-0.02%) to 97.308% when pulling **f9177e204d608e7fa708d57fabf0029746f7774a on ameyjadiye:TEXT-93** into **569dbc09402a6f28334936567a597e3d0db9185c on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text pull request #54: TEXT-93: RandomStringGenerator accepts a list...
Posted by ameyjadiye <gi...@git.apache.org>.
Github user ameyjadiye commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/54#discussion_r123877950
--- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java ---
@@ -76,23 +78,29 @@
private final TextRandomProvider random;
/**
+ * The source of provided charachters.
+ */
+ private final List<Character> characterList;
+
+ /**
* Constructs the generator.
- *
- * @param minimumCodePoint
+ * @param minimumCodePoint
* smallest allowed code point (inclusive)
* @param maximumCodePoint
* largest allowed code point (inclusive)
* @param inclusivePredicates
- * filters for code points
- * @param random
- * source of randomness
+ * filters for code points
--- End diff --
yeah, seems like IntelliJ did this unknowingly, fixed it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #54: TEXT-93: RandomStringGenerator accepts a list of val...
Posted by ameyjadiye <gi...@git.apache.org>.
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/54
As per discussion here[TEXT-93](https://issues.apache.org/jira/browse/TEXT-93) we are good to merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #54: TEXT-93: RandomStringGenerator accepts a list of val...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/54
[](https://:/builds/12093960)
Coverage decreased (-0.02%) to 97.306% when pulling **2dfadf4f8b51ae65d1b1b1f17afa3387b908c31f on ameyjadiye:TEXT-93** into **569dbc09402a6f28334936567a597e3d0db9185c on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text pull request #54: TEXT-93: RandomStringGenerator accepts a list...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-text/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #54: TEXT-93: RandomStringGenerator accepts a list of val...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/54
[](https://:/builds/12108852)
Coverage decreased (-0.02%) to 97.305% when pulling **df30bf96856287478f3a7dfa7f017ca175bdd352 on ameyjadiye:TEXT-93** into **569dbc09402a6f28334936567a597e3d0db9185c on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text pull request #54: TEXT-93: RandomStringGenerator accepts a list...
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/54#discussion_r123874569
--- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java ---
@@ -76,23 +78,29 @@
private final TextRandomProvider random;
/**
+ * The source of provided charachters.
+ */
+ private final List<Character> characterList;
+
+ /**
* Constructs the generator.
- *
- * @param minimumCodePoint
+ * @param minimumCodePoint
* smallest allowed code point (inclusive)
* @param maximumCodePoint
* largest allowed code point (inclusive)
* @param inclusivePredicates
- * filters for code points
- * @param random
- * source of randomness
+ * filters for code points
--- End diff --
Indentation got a bit messed up here, and the param entry for minimumCodePoint too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #54: TEXT-93: RandomStringGenerator accepts a list of val...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/54
[](https://:/builds/12116448)
Coverage decreased (-0.02%) to 97.305% when pulling **9db77088ecc557c2f209dd36972746d6de8dfc4a on ameyjadiye:TEXT-93** into **569dbc09402a6f28334936567a597e3d0db9185c on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org