You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/08 20:44:31 UTC
[GitHub] [commons-io] michielgkalkman opened a new pull request #163: Tiny performance improvements
michielgkalkman opened a new pull request #163:
URL: https://github.com/apache/commons-io/pull/163
I found that copyDirectory(final File srcDir, final File destDir, final FileFilter filter, final boolean preserveFileDate) executes getCanonicalPath() multiple times on the same path. I might be wrong, but that seems wasteful. So, I created this pull request.
I created a unit test based on jmh and it seemed to indicate that the performance indeed improves. However, I am not an expert on benchmarking and profiling and I cannot explain all results. Don't hesitate to show where I went wrong and/or might improve.
See https://github.com/michielgkalkman/PmdPlus/tree/master/src/test/java/org/taHjaj/wo/pmdplus/dup/jmh/org/apache/commons/io (or: https://github.com/michielgkalkman/PmdPlus/commit/10d44959c4441480fa6d1051a9c0fd65bfba4eb2) for some background on what I did test..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory merged pull request #163: Tiny performance improvements
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #163:
URL: https://github.com/apache/commons-io/pull/163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #163: Tiny performance improvements
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #163:
URL: https://github.com/apache/commons-io/pull/163#issuecomment-705832086
[](https://coveralls.io/builds/34040387)
Coverage increased (+0.003%) to 89.475% when pulling **1de01b0c844773361be93d8f53980c2f2f936310 on michielgkalkman:master** into **4d3a6bb54f7d0867cd6f279ce3778719688eb1ec on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #163: Tiny performance improvements
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #163:
URL: https://github.com/apache/commons-io/pull/163#issuecomment-705832086
[](https://coveralls.io/builds/34040387)
Coverage increased (+0.003%) to 89.475% when pulling **1de01b0c844773361be93d8f53980c2f2f936310 on michielgkalkman:master** into **4d3a6bb54f7d0867cd6f279ce3778719688eb1ec on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory merged pull request #163: Tiny performance improvements
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #163:
URL: https://github.com/apache/commons-io/pull/163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #163: Tiny performance improvements
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #163:
URL: https://github.com/apache/commons-io/pull/163#issuecomment-705854234
Looks reasonable even without the performance minor issue, for me, the code is less cluttered with this refactoring. TY! :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #163: Tiny performance improvements
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #163:
URL: https://github.com/apache/commons-io/pull/163#issuecomment-705854234
Looks reasonable even without the performance minor issue, for me, the code is less cluttered with this refactoring. TY! :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org