[GitHub] [kafka] showuon commented on pull request #12165: KAFKA-13905: Fix failing ServerShutdownTest.testCleanShutdownAfterFailedStartupDueToCorruptLogs

[GitBox <gi...@apache.org>]

showuon commented on PR #12165:
URL: https://github.com/apache/kafka/pull/12165#issuecomment-1128325494

   @dengziming , I'd suggest we follow @hachikuji 's advice to add an `assertCause` to fix the failed tests. I can create another JIRA to address our thoughts in this comment: https://github.com/apache/kafka/pull/12165#discussion_r873557577
   
   Also, as Jason mentioned, there are still 2 failed tests:
   ```
   Build / JDK 8 and Scala 2.12 / kafka.server.ServerShutdownTest.testCleanShutdownAfterFailedStartup(String).quorum=kraft
   Build / JDK 8 and Scala 2.12 / kafka.server.ServerShutdownTest.testCleanShutdownWithKRaftControllerUnavailable(String).quorum=kraft
   ```
   
   If you don't have time, you can just disable them first, and create jira ticket for them. Let me know if you need help. I hope we can fix them in our timezone today. The failed tests make my PR build result very bad (and I don't like that, haha)
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org