You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2016/04/09 03:16:06 UTC
Re: Review Request 45489: Replaced reinterpret_cast with static_cast
in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45489/#review127941
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 30, 2016, 4:16 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45489/
> -----------------------------------------------------------
>
> (Updated March 30, 2016, 4:16 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Casting from a virtual base class to a child class should not be
> done with reinterpret_cast. We could use dynamic_cast as well, but
> that has a performance cost; in this case, we know exactly which
> child class the pointer points to, so the performance cost and
> additional safety offered by dynamic_cast is not necessary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp feaffa4334422ec3964f8d079f570061eaf390d2
>
> Diff: https://reviews.apache.org/r/45489/diff/
>
>
> Testing
> -------
>
> make check with GCC 5.3 and recent apple-clang.
>
>
> Thanks,
>
> Neil Conway
>
>