You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/12 20:43:31 UTC
[GitHub] [tvm] mehrdadh opened a new pull request, #11294: [Hexagon]Use requires_hexagon instead of requires_hexagon_toolchain if running on hexagon target
mehrdadh opened a new pull request, #11294:
URL: https://github.com/apache/tvm/pull/11294
We use `requires_hexagon` test fixture when we want to run on hexagon target. `requires_hexagon_toolchain` is used only for cases where we want to build it but not running it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg merged pull request #11294: [Hexagon]Use requires_hexagon instead of requires_hexagon_toolchain if running on hexagon target
Posted by GitBox <gi...@apache.org>.
Lunderberg merged PR #11294:
URL: https://github.com/apache/tvm/pull/11294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #11294: [Hexagon]Use requires_hexagon instead of requires_hexagon_toolchain if running on hexagon target
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #11294:
URL: https://github.com/apache/tvm/pull/11294#issuecomment-1129092792
Hardware test passes and I don't see any skip for Hexagon target. Only one test failed:
```
[ctypes.tests.python.contrib.test_hexagon.test_2d_physical_buffers.TestElementWise.test_execute[nhwc-nhwc-int8-16-32-8x8-nhwc-global-hexagon]](https://jenkins.hwe.octoml.ai/job/hexagon/job/staging/job/main/29/testReport/junit/ctypes.tests.python.contrib.test_hexagon.test_2d_physical_buffers/TestElementWise/test_execute_nhwc_nhwc_int8_16_32_8x8_nhwc_global_hexagon_/)
```
We should investigate that in a follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #11294: [Hexagon]Use requires_hexagon instead of requires_hexagon_toolchain if running on hexagon target
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #11294:
URL: https://github.com/apache/tvm/pull/11294#issuecomment-1128112724
testing on hardware CI to see how many test are failing there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on a diff in pull request #11294: [Hexagon]Use requires_hexagon instead of requires_hexagon_toolchain if running on hexagon target
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on code in PR #11294:
URL: https://github.com/apache/tvm/pull/11294#discussion_r873705022
##########
tests/python/contrib/test_hexagon/test_thread_pool.py:
##########
@@ -66,8 +66,8 @@ def benchmark_func(mod, name, args, hexagon_session):
return evaluator(a, b, c, n).mean
-@requires_hexagon_toolchain
-def test_speedup(hexagon_session, capsys):
+@tvm.testing.requires_hexagon
+def test_speedup(hexagon_session: Session, capsys):
if hexagon_session is None:
Review Comment:
Since `hexagon_session` will be non-null whenever `ANDROID_SERIAL_NUMBER` is set, and `tvm.testing.requires_hexagon` requires that `ANDROID_SERIAL_NUMBER` is set, should we also use this to remove the `if hexagon_session is None` checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #11294: [Hexagon]Use requires_hexagon instead of requires_hexagon_toolchain if running on hexagon target
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #11294:
URL: https://github.com/apache/tvm/pull/11294#issuecomment-1127677015
At first glance, nothing is obviously standing out as the cause of the skipped CI tests. The `ANDROID_SERIAL_NUMBER` is being set in `task_python_hexagon.sh`, and `TVM_TEST_TARGETS` is not being overridden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #11294: [Hexagon]Use requires_hexagon instead of requires_hexagon_toolchain if running on hexagon target
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #11294:
URL: https://github.com/apache/tvm/pull/11294#discussion_r873983774
##########
tests/python/contrib/test_hexagon/test_thread_pool.py:
##########
@@ -66,8 +66,8 @@ def benchmark_func(mod, name, args, hexagon_session):
return evaluator(a, b, c, n).mean
-@requires_hexagon_toolchain
-def test_speedup(hexagon_session, capsys):
+@tvm.testing.requires_hexagon
+def test_speedup(hexagon_session: Session, capsys):
if hexagon_session is None:
Review Comment:
make sense, removed the if condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org