[GitHub] [hbase] virajjasani commented on a change in pull request #939: HBASE-23349 : Notify readers if archival of compacted store files is stuck due to scanners

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #939: HBASE-23349 : Notify readers if archival of compacted store files is stuck due to scanners
URL: https://github.com/apache/hbase/pull/939#discussion_r363103251
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChangedReadersObserver.java
 ##########
 @@ -40,5 +40,16 @@
    * @param memStoreScanners scanner of current memstore
    * @throws IOException e
    */
-  void updateReaders(List<HStoreFile> sfs, List<KeyValueScanner> memStoreScanners) throws IOException;
+  void updateReaders(List<HStoreFile> sfs, List<KeyValueScanner> memStoreScanners)
 
 Review comment:
   Created POJO for the method signature and same is to be used by flush and compaction.
   However, since there are some differences in locking (e.g. using closeLock for flush but not for compaction), it might be good to have private methods for flush and compaction(to be used by main method).
   Updated the PR @ramkrish86 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services