You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/26 23:43:59 UTC
[GitHub] [incubator-superset] john-bodley commented on issue #9213: [fix]
remove chart id from filter_scopes metadata if chart is not in dash anymore
john-bodley commented on issue #9213: [fix] remove chart id from filter_scopes metadata if chart is not in dash anymore
URL: https://github.com/apache/incubator-superset/pull/9213#issuecomment-591701669
@graceguo-supercat part of my confusion was the reuse of the `slice_id` local variable. For readability there may be merit in using a different variable name. This comment is non-blocking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org