You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rpc-dev@xml.apache.org by Martin Poeschl <mp...@marmot.at> on 2001/11/24 18:19:00 UTC

[patch]WebServer.java

- fix javadoc warnings
- break some long lines


Index: ./src/java/org/apache/xmlrpc/WebServer.java
===================================================================
RCS file: /home/cvspublic/xml-rpc/src/java/org/apache/xmlrpc/WebServer.java,v
retrieving revision 1.3
diff -r1.3 WebServer.java
133,135c133,135
<       * Creates a Web server at the specified port number.
<       */
<     public WebServer (int port)
---
 >      * Creates a Web server at the specified port number.
 >      */
 >     public WebServer (int port)
142,144c142,144
<       * Creates a Web server at the specified port number and IP address.
<       */
<     public WebServer (int port, InetAddress add)
---
 >      * Creates a Web server at the specified port number and IP address.
 >      */
 >     public WebServer (int port, InetAddress add)
200,202c200,202
<       * Register a handler object with this name. Methods of this objects will be
<       * callable over XML-RPC as "name.method".
<       */
---
 >      * Register a handler object with this name. Methods of this objects will
 >      * be callable over XML-RPC as "name.method".
 >      */
209,210c209,210
<       * Remove a handler object that was previously registered with this server.
<       */
---
 >      * Remove a handler object that was previously registered with this server.
 >      */
217,220c217,220
<       * Switch client filtering on/off.
<       * @see acceptClient(java.lang.String)
<       * @see denyClient(java.lang.String)
<       */
---
 >      * Switch client filtering on/off.
 >      * @see #acceptClient(java.lang.String)
 >      * @see #denyClient(java.lang.String)
 >      */
227,233c227,233
<       * Add an IP address to the list of accepted clients. The parameter can contain '*' 
as wildcard
<       * character, e.g. "192.168.*.*". You must call setParanoid(true) in order for this 
to have any
<       * effect.
<       *
<       * @see denyClient(java.lang.String)
<       * @see setParanoid(boolean)
<       */
---
 >      * Add an IP address to the list of accepted clients. The parameter can
 >      * contain '*' as wildcard character, e.g. "192.168.*.*". You must call
 >      * setParanoid(true) in order for this to have any effect.
 >      *
 >      * @see #denyClient(java.lang.String)
 >      * @see #setParanoid(boolean)
 >      */
249,255c249,255
<       * Add an IP address to the list of denied clients. The parameter can contain '*' 
as wildcard
<       * character, e.g. "192.168.*.*". You must call setParanoid(true) in order for this 
to have any
<       * effect.
<       *
<       * @see acceptClient(java.lang.String)
<       * @see setParanoid(boolean)
<       */
---
 >      * Add an IP address to the list of denied clients. The parameter can
 >      * contain '*' as wildcard character, e.g. "192.168.*.*". You must call
 >      * setParanoid(true) in order for this to have any effect.
 >      *
 >      * @see #acceptClient(java.lang.String)
 >      * @see #setParanoid(boolean)
 >      */
265c265,266
<             throw new IllegalArgumentException ("\""+address + "\" does not represent a 
valid IP address");
---
 >             throw new IllegalArgumentException ("\"" + address
 >                     + "\" does not represent a valid IP address");
290,291c291,292
<       * Listens for client requests until stopped.
<       */
---
 >      * Listens for client requests until stopped.
 >      */
348,349c349,350
<       * Stop listening on the server port.
<       */
---
 >      * Stop listening on the server port.
 >      */
360,361d360
<
<
606c605,606
<                 throw new Exception ("\""+address + "\" does not represent a valid IP 
address");
---
 >                 throw new Exception ("\"" + address
 >                         + "\" does not represent a valid IP address");

The command completed successfully.


Re: [patch]WebServer.java

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Martin Poeschl <mp...@marmot.at> writes:

> hmm i'm sure i saw a setting in mozilla to stop line breaking ...

I know that there's such an option in 4.7x.

I see a "Wrap plain text messages at [72] characters" option under
Preferences > Mail & Newsgroups > Message Composition in Mozilla
0.9.5.  You could set that to a really big value (though it would be
nice if there were an option to to turn it off entirely).

> i sent the diff as attachement to jason

Thanks.

Re: [patch]WebServer.java

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Martin Poeschl <mp...@marmot.at> writes:

> hmm i'm sure i saw a setting in mozilla to stop line breaking ...

I know that there's such an option in 4.7x.

I see a "Wrap plain text messages at [72] characters" option under
Preferences > Mail & Newsgroups > Message Composition in Mozilla
0.9.5.  You could set that to a really big value (though it would be
nice if there were an option to to turn it off entirely).

> i sent the diff as attachement to jason

Thanks.

Re: [patch]WebServer.java

Posted by Martin Poeschl <mp...@marmot.at>.
Daniel Rall wrote:

> Jason van Zyl <jv...@zenplex.com> writes:
> 
> 
>>Can you send me that as an attachment, my email client screws up patches.
>>
> 
> Martin's email client wrapped the lines around 78 columns.  Martin,
> can you also send as unidiff in the future (i.e. cvs diff -u)?
> 
>                              Thanks, Dan
> 
oops yes ... haven't sent diffs for a while ;-)


hmm i'm sure i saw a setting in mozilla to stop line breaking ...

i sent the diff as attachement to jason

martin






Re: [patch]WebServer.java

Posted by Martin Poeschl <mp...@marmot.at>.
Daniel Rall wrote:

> Jason van Zyl <jv...@zenplex.com> writes:
> 
> 
>>Can you send me that as an attachment, my email client screws up patches.
>>
> 
> Martin's email client wrapped the lines around 78 columns.  Martin,
> can you also send as unidiff in the future (i.e. cvs diff -u)?
> 
>                              Thanks, Dan
> 
oops yes ... haven't sent diffs for a while ;-)


hmm i'm sure i saw a setting in mozilla to stop line breaking ...

i sent the diff as attachement to jason

martin






Re: [patch]WebServer.java

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Jason van Zyl <jv...@zenplex.com> writes:

> Can you send me that as an attachment, my email client screws up patches.

Martin's email client wrapped the lines around 78 columns.  Martin,
can you also send as unidiff in the future (i.e. cvs diff -u)?

                             Thanks, Dan

Re: [patch]WebServer.java

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Jason van Zyl <jv...@zenplex.com> writes:

> Can you send me that as an attachment, my email client screws up patches.

Martin's email client wrapped the lines around 78 columns.  Martin,
can you also send as unidiff in the future (i.e. cvs diff -u)?

                             Thanks, Dan

Re: [patch]WebServer.java

Posted by Jason van Zyl <jv...@zenplex.com>.
On 11/24/01 12:19 PM, "Martin Poeschl" <mp...@marmot.at> wrote:

Can you send me that as an attachment, my email client screws up patches.


> - fix javadoc warnings
> - break some long lines
> 
> 
> Index: ./src/java/org/apache/xmlrpc/WebServer.java
> ===================================================================
> RCS file: /home/cvspublic/xml-rpc/src/java/org/apache/xmlrpc/WebServer.java,v
> retrieving revision 1.3
> diff -r1.3 WebServer.java
> 133,135c133,135
> <       * Creates a Web server at the specified port number.
> <       */
> <     public WebServer (int port)
> ---
>>      * Creates a Web server at the specified port number.
>>      */
>>     public WebServer (int port)
> 142,144c142,144
> <       * Creates a Web server at the specified port number and IP address.
> <       */
> <     public WebServer (int port, InetAddress add)
> ---
>>      * Creates a Web server at the specified port number and IP address.
>>      */
>>     public WebServer (int port, InetAddress add)
> 200,202c200,202
> <       * Register a handler object with this name. Methods of this objects
> will be
> <       * callable over XML-RPC as "name.method".
> <       */
> ---
>>      * Register a handler object with this name. Methods of this objects will
>>      * be callable over XML-RPC as "name.method".
>>      */
> 209,210c209,210
> <       * Remove a handler object that was previously registered with this
> server.
> <       */
> ---
>>      * Remove a handler object that was previously registered with this
>> server.
>>      */
> 217,220c217,220
> <       * Switch client filtering on/off.
> <       * @see acceptClient(java.lang.String)
> <       * @see denyClient(java.lang.String)
> <       */
> ---
>>      * Switch client filtering on/off.
>>      * @see #acceptClient(java.lang.String)
>>      * @see #denyClient(java.lang.String)
>>      */
> 227,233c227,233
> <       * Add an IP address to the list of accepted clients. The parameter can
> contain '*' 
> as wildcard
> <       * character, e.g. "192.168.*.*". You must call setParanoid(true) in
> order for this 
> to have any
> <       * effect.
> <       *
> <       * @see denyClient(java.lang.String)
> <       * @see setParanoid(boolean)
> <       */
> ---
>>      * Add an IP address to the list of accepted clients. The parameter can
>>      * contain '*' as wildcard character, e.g. "192.168.*.*". You must call
>>      * setParanoid(true) in order for this to have any effect.
>>      *
>>      * @see #denyClient(java.lang.String)
>>      * @see #setParanoid(boolean)
>>      */
> 249,255c249,255
> <       * Add an IP address to the list of denied clients. The parameter can
> contain '*' 
> as wildcard
> <       * character, e.g. "192.168.*.*". You must call setParanoid(true) in
> order for this 
> to have any
> <       * effect.
> <       *
> <       * @see acceptClient(java.lang.String)
> <       * @see setParanoid(boolean)
> <       */
> ---
>>      * Add an IP address to the list of denied clients. The parameter can
>>      * contain '*' as wildcard character, e.g. "192.168.*.*". You must call
>>      * setParanoid(true) in order for this to have any effect.
>>      *
>>      * @see #acceptClient(java.lang.String)
>>      * @see #setParanoid(boolean)
>>      */
> 265c265,266
> <             throw new IllegalArgumentException ("\""+address + "\" does not
> represent a 
> valid IP address");
> ---
>>             throw new IllegalArgumentException ("\"" + address
>>                     + "\" does not represent a valid IP address");
> 290,291c291,292
> <       * Listens for client requests until stopped.
> <       */
> ---
>>      * Listens for client requests until stopped.
>>      */
> 348,349c349,350
> <       * Stop listening on the server port.
> <       */
> ---
>>      * Stop listening on the server port.
>>      */
> 360,361d360
> <
> <
> 606c605,606
> <                 throw new Exception ("\""+address + "\" does not represent a
> valid IP 
> address");
> ---
>>                 throw new Exception ("\"" + address
>>                         + "\" does not represent a valid IP address");
> 
> The command completed successfully.

-- 

jvz.

Jason van Zyl

http://tambora.zenplex.org
http://jakarta.apache.org/turbine
http://jakarta.apache.org/velocity
http://jakarta.apache.org/alexandria
http://jakarta.apache.org/commons



Re: [patch]WebServer.java

Posted by Jason van Zyl <jv...@zenplex.com>.
On 11/24/01 12:19 PM, "Martin Poeschl" <mp...@marmot.at> wrote:

Can you send me that as an attachment, my email client screws up patches.


> - fix javadoc warnings
> - break some long lines
> 
> 
> Index: ./src/java/org/apache/xmlrpc/WebServer.java
> ===================================================================
> RCS file: /home/cvspublic/xml-rpc/src/java/org/apache/xmlrpc/WebServer.java,v
> retrieving revision 1.3
> diff -r1.3 WebServer.java
> 133,135c133,135
> <       * Creates a Web server at the specified port number.
> <       */
> <     public WebServer (int port)
> ---
>>      * Creates a Web server at the specified port number.
>>      */
>>     public WebServer (int port)
> 142,144c142,144
> <       * Creates a Web server at the specified port number and IP address.
> <       */
> <     public WebServer (int port, InetAddress add)
> ---
>>      * Creates a Web server at the specified port number and IP address.
>>      */
>>     public WebServer (int port, InetAddress add)
> 200,202c200,202
> <       * Register a handler object with this name. Methods of this objects
> will be
> <       * callable over XML-RPC as "name.method".
> <       */
> ---
>>      * Register a handler object with this name. Methods of this objects will
>>      * be callable over XML-RPC as "name.method".
>>      */
> 209,210c209,210
> <       * Remove a handler object that was previously registered with this
> server.
> <       */
> ---
>>      * Remove a handler object that was previously registered with this
>> server.
>>      */
> 217,220c217,220
> <       * Switch client filtering on/off.
> <       * @see acceptClient(java.lang.String)
> <       * @see denyClient(java.lang.String)
> <       */
> ---
>>      * Switch client filtering on/off.
>>      * @see #acceptClient(java.lang.String)
>>      * @see #denyClient(java.lang.String)
>>      */
> 227,233c227,233
> <       * Add an IP address to the list of accepted clients. The parameter can
> contain '*' 
> as wildcard
> <       * character, e.g. "192.168.*.*". You must call setParanoid(true) in
> order for this 
> to have any
> <       * effect.
> <       *
> <       * @see denyClient(java.lang.String)
> <       * @see setParanoid(boolean)
> <       */
> ---
>>      * Add an IP address to the list of accepted clients. The parameter can
>>      * contain '*' as wildcard character, e.g. "192.168.*.*". You must call
>>      * setParanoid(true) in order for this to have any effect.
>>      *
>>      * @see #denyClient(java.lang.String)
>>      * @see #setParanoid(boolean)
>>      */
> 249,255c249,255
> <       * Add an IP address to the list of denied clients. The parameter can
> contain '*' 
> as wildcard
> <       * character, e.g. "192.168.*.*". You must call setParanoid(true) in
> order for this 
> to have any
> <       * effect.
> <       *
> <       * @see acceptClient(java.lang.String)
> <       * @see setParanoid(boolean)
> <       */
> ---
>>      * Add an IP address to the list of denied clients. The parameter can
>>      * contain '*' as wildcard character, e.g. "192.168.*.*". You must call
>>      * setParanoid(true) in order for this to have any effect.
>>      *
>>      * @see #acceptClient(java.lang.String)
>>      * @see #setParanoid(boolean)
>>      */
> 265c265,266
> <             throw new IllegalArgumentException ("\""+address + "\" does not
> represent a 
> valid IP address");
> ---
>>             throw new IllegalArgumentException ("\"" + address
>>                     + "\" does not represent a valid IP address");
> 290,291c291,292
> <       * Listens for client requests until stopped.
> <       */
> ---
>>      * Listens for client requests until stopped.
>>      */
> 348,349c349,350
> <       * Stop listening on the server port.
> <       */
> ---
>>      * Stop listening on the server port.
>>      */
> 360,361d360
> <
> <
> 606c605,606
> <                 throw new Exception ("\""+address + "\" does not represent a
> valid IP 
> address");
> ---
>>                 throw new Exception ("\"" + address
>>                         + "\" does not represent a valid IP address");
> 
> The command completed successfully.

-- 

jvz.

Jason van Zyl

http://tambora.zenplex.org
http://jakarta.apache.org/turbine
http://jakarta.apache.org/velocity
http://jakarta.apache.org/alexandria
http://jakarta.apache.org/commons