You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/17 03:37:09 UTC
[GitHub] [druid] codecov-io commented on issue #9516: More efficient join
filter rewrites
codecov-io commented on issue #9516: More efficient join filter rewrites
URL: https://github.com/apache/druid/pull/9516#issuecomment-599861337
# [Codecov](https://codecov.io/gh/apache/druid/pull/9516?src=pr&el=h1) Report
> Merging [#9516](https://codecov.io/gh/apache/druid/pull/9516?src=pr&el=desc) into [master](https://codecov.io/gh/apache/druid/commit/e7b3dd9cd1c8a95855ee672e2fcbfe1b895ccc37?src=pr&el=desc) will **increase** coverage by `1.01%`.
> The diff coverage is `88.31%`.
[](https://codecov.io/gh/apache/druid/pull/9516?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9516 +/- ##
============================================
+ Coverage 63.59% 64.6% +1.01%
- Complexity 23583 23639 +56
============================================
Files 3056 2939 -117
Lines 126205 120119 -6086
Branches 17456 16099 -1357
============================================
- Hits 80254 77608 -2646
+ Misses 38756 35528 -3228
+ Partials 7195 6983 -212
```
| [Impacted Files](https://codecov.io/gh/apache/druid/pull/9516?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/druid/query/groupby/GroupByQuery.java](https://codecov.io/gh/apache/druid/pull/9516/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvcXVlcnkvZ3JvdXBieS9Hcm91cEJ5UXVlcnkuamF2YQ==) | `92.16% <ø> (ø)` | `128 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/druid/query/topn/TopNQuery.java](https://codecov.io/gh/apache/druid/pull/9516/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvcXVlcnkvdG9wbi9Ub3BOUXVlcnkuamF2YQ==) | `49.23% <ø> (ø)` | `18 <0> (ø)` | :arrow_down: |
| [...apache/druid/query/timeseries/TimeseriesQuery.java](https://codecov.io/gh/apache/druid/pull/9516/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvcXVlcnkvdGltZXNlcmllcy9UaW1lc2VyaWVzUXVlcnkuamF2YQ==) | `47.05% <ø> (ø)` | `18 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/druid/query/scan/ScanQuery.java](https://codecov.io/gh/apache/druid/pull/9516/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvcXVlcnkvc2Nhbi9TY2FuUXVlcnkuamF2YQ==) | `56.97% <ø> (ø)` | `26 <0> (ø)` | :arrow_down: |
| [...g/apache/druid/server/LocalQuerySegmentWalker.java](https://codecov.io/gh/apache/druid/pull/9516/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kcnVpZC9zZXJ2ZXIvTG9jYWxRdWVyeVNlZ21lbnRXYWxrZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ng/src/main/java/org/apache/druid/query/Query.java](https://codecov.io/gh/apache/druid/pull/9516/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvcXVlcnkvUXVlcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/druid/segment/join/lookup/LookupJoinable.java](https://codecov.io/gh/apache/druid/pull/9516/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvc2VnbWVudC9qb2luL2xvb2t1cC9Mb29rdXBKb2luYWJsZS5qYXZh) | `47.61% <0%> (+16.04%)` | `6 <0> (+2)` | :arrow_up: |
| [...druid/segment/join/table/IndexedTableJoinable.java](https://codecov.io/gh/apache/druid/pull/9516/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvc2VnbWVudC9qb2luL3RhYmxlL0luZGV4ZWRUYWJsZUpvaW5hYmxlLmphdmE=) | `79.41% <0%> (+11.55%)` | `12 <0> (+2)` | :arrow_up: |
| [...ain/java/org/apache/druid/query/QueryContexts.java](https://codecov.io/gh/apache/druid/pull/9516/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvcXVlcnkvUXVlcnlDb250ZXh0cy5qYXZh) | `56.09% <0%> (-1.41%)` | `24 <0> (ø)` | |
| [.../java/org/apache/druid/segment/join/Joinables.java](https://codecov.io/gh/apache/druid/pull/9516/diff?src=pr&el=tree#diff-cHJvY2Vzc2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvc2VnbWVudC9qb2luL0pvaW5hYmxlcy5qYXZh) | `97.61% <100%> (+0.05%)` | `23 <0> (ø)` | :arrow_down: |
| ... and [146 more](https://codecov.io/gh/apache/druid/pull/9516/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/druid/pull/9516?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/druid/pull/9516?src=pr&el=footer). Last update [e7b3dd9...3a449c7](https://codecov.io/gh/apache/druid/pull/9516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org