You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/12/09 20:09:22 UTC
[GitHub] [myfaces] KyleAure opened a new pull request, #419: [SPEC 1574] Ensure top level ul does not have border attribute
KyleAure opened a new pull request, #419:
URL: https://github.com/apache/myfaces/pull/419
Based on the SPEC issue here: https://github.com/jakartaee/faces/issues/1574
When layout="list" the border attribute should be ignored.
When a form like this:
```xml
<h:form id="form">
<h:selectManyCheckbox id="input" layout="list" border="5">
...
</h:selectManyCheckbox>
</h:form>
```
Is rendered the current output is:
```xml
<html>
<head/>
<body>
<form id="form" name="form" method="post" action="/LayoutAttribute/selectManyCheckBox.xhtml" enctype="application/x-www-form-urlencoded">
<ul id="form:input" border="5">
...
</ul>
</body>
</html>
```
Based on the spec we should be rendering:
```xml
<html>
<head/>
<body>
<form id="form" name="form" method="post" action="/LayoutAttribute/selectManyCheckBox.xhtml" enctype="application/x-www-form-urlencoded">
<ul id="form:input">
...
</ul>
</body>
</html>
```
This is because we are incorrectly starting this element with table passthrough properties, instead of ul passthrough properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #419: [SPEC 1574] Ensure top level ul does not have border attribute
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #419:
URL: https://github.com/apache/myfaces/pull/419#issuecomment-1344751981
These look good to me thanks for the PR. They might want you to open a JIRA ticket if you have not already so we can track this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #419: [SPEC 1574 / MYFACES-4528 ] Ensure top level ul does not have border attribute
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #419:
URL: https://github.com/apache/myfaces/pull/419#issuecomment-1345269487
Also does this fix need to be backported to 2.3 and 2.3-next?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #419: [SPEC 1574 / MYFACES-4528 ] Ensure top level ul does not have border attribute
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #419:
URL: https://github.com/apache/myfaces/pull/419#issuecomment-1353453532
@melloware It looks like the layout=list was only added to 4.0 (per the spec). I thought it was added to 2.3-next, but was mistaken. So no need to backport.
https://github.com/apache/myfaces/pull/224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #419: [SPEC 1574] Ensure top level ul does not have border attribute
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #419:
URL: https://github.com/apache/myfaces/pull/419#issuecomment-1344767114
This looks good -- just tested locally. Thanks for providing a patch and making the JIRA.
Related to which, I think the community should create an issues tab to allow users to create issues in this repo since JIRA is disabled for new signups. We can follow on on this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied merged pull request #419: [SPEC 1574 / MYFACES-4528 ] Ensure top level ul does not have border attribute
Posted by GitBox <gi...@apache.org>.
volosied merged PR #419:
URL: https://github.com/apache/myfaces/pull/419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] KyleAure commented on pull request #419: [SPEC 1574] Ensure top level ul does not have border attribute
Posted by GitBox <gi...@apache.org>.
KyleAure commented on PR #419:
URL: https://github.com/apache/myfaces/pull/419#issuecomment-1344759061
@melloware Thanks for the heads up. I created the issue here: https://issues.apache.org/jira/browse/MYFACES-4528
Sorry, should have done that first. This is my first commit to this community and didn't realize you were using Jira
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #419: [SPEC 1574 / MYFACES-4528 ] Ensure top level ul does not have border attribute
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #419:
URL: https://github.com/apache/myfaces/pull/419#issuecomment-1345269412
I actually prefer GitHub Issues myself but yes an easy way for users to report issue we can always make a JIRA ticket if we discover its a real issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #419: [SPEC 1574 / MYFACES-4528 ] Ensure top level ul does not have border attribute
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #419:
URL: https://github.com/apache/myfaces/pull/419#issuecomment-1346589881
I think so. It's a fairly simple fix and should apply easily to those branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org