You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/05/25 03:04:24 UTC
Review Request 67310: Updated hashmap and LinkedHashMap to return
vectors from values().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67310/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
Repository: mesos
Description
-------
std::list is prefered over std::vector for performance reasons, unless
frequent std::list advantageous operations are performed.
Diffs
-----
3rdparty/stout/include/stout/hashmap.hpp 698fa0f3d198342dfc9743232992e648dbb1e6e6
3rdparty/stout/include/stout/linkedhashmap.hpp 33cc86ad132775c7b4f33fc78de63afc39d1afef
3rdparty/stout/tests/linkedhashmap_tests.cpp 712752a60e23980652889dcecaeb1c20e233c94e
Diff: https://reviews.apache.org/r/67310/diff/1/
Testing
-------
Thanks,
Benjamin Mahler
Re: Review Request 67310: Updated hashmap and LinkedHashMap to return
vectors from values().
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67310/#review204074
-----------------------------------------------------------
The description is not very clear to me. How about the following:
`std::vector` is preferred over `std::list` for performance since we
usually use the returned list as a constant copy of keys or values.
Also, there are a couple more places to replace `std::list`s with `std::vector`s for consistency (and maybe performance, although I haven't checked the usages yet):
`BoundedHashMap::keys()`
`BoundedHashMap::values()`
`Multimap::get()`
`multihashmap::get()`
- Chun-Hung Hsiao
On May 25, 2018, 3:04 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67310/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 3:04 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> std::list is prefered over std::vector for performance reasons, unless
> frequent std::list advantageous operations are performed.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/hashmap.hpp 698fa0f3d198342dfc9743232992e648dbb1e6e6
> 3rdparty/stout/include/stout/linkedhashmap.hpp 33cc86ad132775c7b4f33fc78de63afc39d1afef
> 3rdparty/stout/tests/linkedhashmap_tests.cpp 712752a60e23980652889dcecaeb1c20e233c94e
>
>
> Diff: https://reviews.apache.org/r/67310/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 67310: Updated hashmap and LinkedHashMap to return
vectors from values().
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67310/#review204089
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On May 25, 2018, 3:04 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67310/
> -----------------------------------------------------------
>
> (Updated May 25, 2018, 3:04 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> std::list is prefered over std::vector for performance reasons, unless
> frequent std::list advantageous operations are performed.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/hashmap.hpp 698fa0f3d198342dfc9743232992e648dbb1e6e6
> 3rdparty/stout/include/stout/linkedhashmap.hpp 33cc86ad132775c7b4f33fc78de63afc39d1afef
> 3rdparty/stout/tests/linkedhashmap_tests.cpp 712752a60e23980652889dcecaeb1c20e233c94e
>
>
> Diff: https://reviews.apache.org/r/67310/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Mahler
>
>