You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2016/06/25 09:26:21 UTC

[GitHub] spark pull request #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/13905

    [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

    ## What changes were proposed in this pull request?
    
    This PR adds a new logical optimizer, `CollapseEmptyPlan`, to collapse a logical plain consisting of only empty LocalRelations.
    
    **Before**
    ```scala
    scala> sql("select a from (select explode(array(1,2,3)) a) where 1=0 group by a having count(*)>1 order by a").explain
    == Physical Plan ==
    *Sort [a#15 ASC], true, 0
    +- Exchange rangepartitioning(a#15 ASC, 200)
       +- *Project [a#15]
          +- *Filter (count(1)#17L > 1)
             +- *HashAggregate(keys=[a#15], functions=[count(1)])
                +- Exchange hashpartitioning(a#15, 200)
                   +- *HashAggregate(keys=[a#15], functions=[partial_count(1)])
                      +- Generate explode([1,2,3]), false, false, [a#15]
                         +- LocalTableScan <empty>
    ```
    
    **After**
    ```scala
    scala> sql("select a from (select explode(array(1,2,3)) a) where 1=0 group by a having count(*)>1 order by a").explain
    == Physical Plan ==
    LocalTableScan <empty>, [a#15]
    ```
    
    ## How was this patch tested?
    
    Pass the Jenkins tests (including a new testsuite).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-16208

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13905.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13905
    
----
commit db0aeb9fa9a38b1deb44399f434b1e549a79be6e
Author: Dongjoon Hyun <do...@apache.org>
Date:   2016-06-25T09:18:44Z

    [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61230/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    **[Test build #61234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61234/consoleFull)** for PR 13905 at commit [`34043a0`](https://github.com/apache/spark/commit/34043a09c91b33fe3d5647b660cec452b97a288e).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    **[Test build #61228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61228/consoleFull)** for PR 13905 at commit [`db0aeb9`](https://github.com/apache/spark/commit/db0aeb9fa9a38b1deb44399f434b1e549a79be6e).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61228/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    **[Test build #61234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61234/consoleFull)** for PR 13905 at commit [`34043a0`](https://github.com/apache/spark/commit/34043a09c91b33fe3d5647b660cec452b97a288e).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    **[Test build #61230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61230/consoleFull)** for PR 13905 at commit [`cb57522`](https://github.com/apache/spark/commit/cb57522567762031b01b63ead12997d9e5bcca79).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    **[Test build #61230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61230/consoleFull)** for PR 13905 at commit [`cb57522`](https://github.com/apache/spark/commit/cb57522567762031b01b63ead12997d9e5bcca79).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimi...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun closed the pull request at:

    https://github.com/apache/spark/pull/13905


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    **[Test build #61228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61228/consoleFull)** for PR 13905 at commit [`db0aeb9`](https://github.com/apache/spark/commit/db0aeb9fa9a38b1deb44399f434b1e549a79be6e).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #13905: [SPARK-16208][SQL] Add `CollapseEmptyPlan` optimizer

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13905
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61234/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org