You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/13 00:38:05 UTC

[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #5295: [ISSUE #5294]fix ClassLoad path optimization

Oliverwqcwrw commented on code in PR #5295:
URL: https://github.com/apache/rocketmq/pull/5295#discussion_r994008382


##########
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java:
##########
@@ -894,15 +894,19 @@ public boolean executeSendMessageBack(List<MessageExt> msgList, String brokerNam
     }
 
     private void initialTransaction() {
-        this.transactionalMessageService = ServiceProvider.loadClass(ServiceProvider.TRANSACTION_SERVICE_ID, TransactionalMessageService.class);

Review Comment:
   IMO,The point of this is to effectively use the SPI mechanism so that users can extend their own implementation, so load this path



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org