You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "metarutaiga (via GitHub)" <gi...@apache.org> on 2024/10/21 12:01:00 UTC
[PR] risc-v/esp32: Fixed path of File-system mount point [nuttx]
metarutaiga opened a new pull request, #14432:
URL: https://github.com/apache/nuttx/pull/14432
*Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
the File-system Mount Point is miss in codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] risc-v/esp32: Fixed path of File-system mount point [nuttx]
Posted by "metarutaiga (via GitHub)" <gi...@apache.org>.
metarutaiga commented on code in PR #14432:
URL: https://github.com/apache/nuttx/pull/14432#discussion_r1809813121
##########
boards/risc-v/esp32c3-legacy/common/src/esp32c3_board_spiflash.c:
##########
Review Comment:
Yeah, I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] risc-v/esp32: Fixed path of File-system mount point [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14432:
URL: https://github.com/apache/nuttx/pull/14432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] risc-v/esp32: Fixed path of File-system mount point [nuttx]
Posted by "tmedicci (via GitHub)" <gi...@apache.org>.
tmedicci commented on code in PR #14432:
URL: https://github.com/apache/nuttx/pull/14432#discussion_r1809203330
##########
boards/risc-v/esp32c3-legacy/common/src/esp32c3_board_spiflash.c:
##########
Review Comment:
It seems this file doesn't have any reference to `nuttx/config.h` (and that is probably the reason for https://github.com/apache/nuttx/actions/runs/11443502523/job/31836407638#step:7:720).
##########
boards/risc-v/esp32c6/common/src/esp_board_spiflash.c:
##########
Review Comment:
Probably the same here.
##########
boards/risc-v/esp32h2/common/src/esp_board_spiflash.c:
##########
Review Comment:
Probably the same here.
##########
boards/risc-v/esp32c3/common/src/esp_board_spiflash.c:
##########
Review Comment:
Same here (about the config).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org