You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2018/01/21 23:36:38 UTC

logging-log4j2 git commit: [LOG4J2-2208] Add debug logging to org.apache.logging.log4j.mongodb.MongoDbConnection.

Repository: logging-log4j2
Updated Branches:
  refs/heads/master 78cdcb904 -> aa452fc13


[LOG4J2-2208] Add debug logging to
org.apache.logging.log4j.mongodb.MongoDbConnection.

Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/aa452fc1
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/aa452fc1
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/aa452fc1

Branch: refs/heads/master
Commit: aa452fc13e7a53791b5f13106e5983ca71d51eeb
Parents: 78cdcb9
Author: Gary Gregory <ga...@gmail.com>
Authored: Sun Jan 21 16:36:35 2018 -0700
Committer: Gary Gregory <ga...@gmail.com>
Committed: Sun Jan 21 16:36:35 2018 -0700

----------------------------------------------------------------------
 .../apache/logging/log4j/mongodb/MongoDbConnection.java  | 11 +++++++++--
 src/changes/changes.xml                                  |  3 +++
 2 files changed, 12 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/aa452fc1/log4j-mongodb/src/main/java/org/apache/logging/log4j/mongodb/MongoDbConnection.java
----------------------------------------------------------------------
diff --git a/log4j-mongodb/src/main/java/org/apache/logging/log4j/mongodb/MongoDbConnection.java b/log4j-mongodb/src/main/java/org/apache/logging/log4j/mongodb/MongoDbConnection.java
index 4ad0671..c3f6eaa 100644
--- a/log4j-mongodb/src/main/java/org/apache/logging/log4j/mongodb/MongoDbConnection.java
+++ b/log4j-mongodb/src/main/java/org/apache/logging/log4j/mongodb/MongoDbConnection.java
@@ -29,6 +29,7 @@ import org.bson.Transformer;
 import com.mongodb.BasicDBObject;
 import com.mongodb.DB;
 import com.mongodb.DBCollection;
+import com.mongodb.Mongo;
 import com.mongodb.MongoException;
 import com.mongodb.WriteConcern;
 
@@ -57,11 +58,13 @@ public final class MongoDbConnection extends AbstractNoSqlConnection<BasicDBObje
     public MongoDbConnection(final DB database, final WriteConcern writeConcern, final String collectionName,
             final Boolean isCapped, final Integer collectionSize) {
         if (database.collectionExists(collectionName)) {
+            LOGGER.debug("Gettting collection {}", collectionName);
             collection = database.getCollection(collectionName);
         } else {
             final BasicDBObject options = new BasicDBObject();
             options.put("capped", isCapped);
             options.put("size", collectionSize);
+            LOGGER.debug("Creating collection {} (capped = {}, size = {})", collectionName, isCapped, collectionSize);
             this.collection = database.createCollection(collectionName, options);
         }
         this.writeConcern = writeConcern;
@@ -80,7 +83,9 @@ public final class MongoDbConnection extends AbstractNoSqlConnection<BasicDBObje
     @Override
     public void insertObject(final NoSqlObject<BasicDBObject> object) {
         try {
-            this.collection.insert(object.unwrap(), this.writeConcern);
+            BasicDBObject unwrapped = object.unwrap();
+            LOGGER.debug("Inserting object {}", unwrapped);
+            this.collection.insert(unwrapped, this.writeConcern);
         } catch (final MongoException e) {
             throw new AppenderLoggingException("Failed to write log event to MongoDB due to error: " + e.getMessage(),
                     e);
@@ -90,7 +95,9 @@ public final class MongoDbConnection extends AbstractNoSqlConnection<BasicDBObje
     @Override
     public void closeImpl() {
         // LOG4J2-1196
-        this.collection.getDB().getMongo().close();
+        Mongo mongo = this.collection.getDB().getMongo();
+        LOGGER.debug("Closing {} client {}", mongo.getClass().getSimpleName(), mongo);
+        mongo.close();
     }
 
 }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/aa452fc1/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 1b5e634..e460b96 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -122,6 +122,9 @@
       <action issue="LOG4J2-2206" dev="ggregory" type="add">
         Add method org.apache.logging.log4j.core.util.WatchManager.reset(File) and reset().
       </action>
+      <action issue="LOG4J2-2208" dev="ggregory" type="add">
+        Add debug logging to org.apache.logging.log4j.mongodb.MongoDbConnection.
+      </action>
     </release>
     <release version="2.10.0" date="2017-11-18" description="GA Release 2.10.0">
       <action issue="LOG4J2-2120" dev="mikes" type="add" due-to="Carter Douglas Kozak ">