[GitHub] [incubator-celeborn] onebox-li commented on a diff in pull request #1592: [CELEBORN-680][DOC] Refresh celeborn configurations in doc

["onebox-li (via GitHub)" <gi...@apache.org>]

onebox-li commented on code in PR #1592:
URL: https://github.com/apache/incubator-celeborn/pull/1592#discussion_r1229342701


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2555,7 +2555,7 @@ object CelebornConf extends Logging {
       .categories("client")
       .version("0.3.0")
       .doc("Amount of Netty in-flight requests per worker. The maximum memory is " +
-        "`celeborn.push.maxReqsInFlight` * `celeborn.push.buffer.max.size` * " +
+        "`celeborn.client.push.maxReqsInFlight` * `celeborn.push.buffer.max.size` * " +
         "compression ratio(1 in worst case), default: 64Kib * 32 = 2Mib")

Review Comment:
   Here can we change to 64KiB? I was confused about why 32.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org