You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by tonysun83 <gi...@git.apache.org> on 2017/02/23 20:35:14 UTC

[GitHub] couchdb-couch-mrview pull request #66: Add error clause for built in reduce ...

GitHub user tonysun83 opened a pull request:

    https://github.com/apache/couchdb-couch-mrview/pull/66

    Add error clause for built in reduce errors

    When users provide invalid input to a reduce function, an error is
    return by couch_query_servers instead of crashing. We take this error
    and transform it into a meaningful message to the user.
    
    This is a supplement PR to https://github.com/apache/couchdb-couch/pull/229.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch-mrview 70794-reduce-sum-errors

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch-mrview/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #66
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-mrview pull request #66: Add error clause for built in reduce ...

Posted by tonysun83 <gi...@git.apache.org>.
Github user tonysun83 closed the pull request at:

    https://github.com/apache/couchdb-couch-mrview/pull/66


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-mrview pull request #66: Add error clause for built in reduce ...

Posted by tonysun83 <gi...@git.apache.org>.
Github user tonysun83 commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch-mrview/pull/66#discussion_r102811714
  
    --- Diff: src/couch_mrview_http.erl ---
    @@ -411,6 +411,12 @@ row_to_json(Row) ->
         row_to_json(Id, Row).
     
     
    +row_to_json(builtin_reduce_error, Row) ->
    +    Value = couch_util:get_value(value, Row),
    +    Reason = couch_util:get_value(reason, Row),
    +    Obj = {[{error, builtin_reduce_error}, {reason, Reason},
    +        {cause_by, Value}]},
    --- End diff --
    
    need to change to caused_by



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-mrview issue #66: Add error clause for built in reduce errors

Posted by tonysun83 <gi...@git.apache.org>.
Github user tonysun83 commented on the issue:

    https://github.com/apache/couchdb-couch-mrview/pull/66
  
    This is no longer needed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---