[GitHub] [hbase] binlijin commented on a change in pull request #732: HBASE-23187 Update parent region state to SPLIT in meta

[GitBox <gi...@apache.org>]

binlijin commented on a change in pull request #732: HBASE-23187 Update parent region state to SPLIT in meta
URL: https://github.com/apache/hbase/pull/732#discussion_r336816984
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
 ##########
 @@ -1580,6 +1580,7 @@ public static void splitRegion(Connection connection, RegionInfo parent, long pa
       Put putParent = makePutFromRegionInfo(RegionInfoBuilder.newBuilder(parent)
                         .setOffline(true)
                         .setSplit(true).build(), time);
+      addRegionStateToPut(putParent, State.SPLIT);
 
 Review comment:
   The SPLIT_PARENT add back when enable table, and the code is in: 
   https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/EnableTableProcedure.java#L114
   https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L329
   https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L349
   And i not am familiar with all this logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services