[GitHub] [couchdb] nickva opened a new pull request #2569: Let couch_jobs use its own metadata key

[GitBox <gi...@apache.org>]

nickva opened a new pull request #2569: Let couch_jobs use its own metadata key
URL: https://github.com/apache/couchdb/pull/2569
 
 
   Previously, if the metadata key is bumped in a transaction the same transaction
   could not be used to add jobs with `couch_jobs`. That's because metadata is a
   versionstamped value, and when set, it cannot be read back until that
   transaction has committed. In `fabric2_fdb` there is a process dict key that is
   set which declares that metadata was already read, which happens before any db
   update, however `couch_jobs` uses it's own caching mechanism and doesn't know
   about that pdict key.
   
   It would be tempting to re-use the same pdict key and just set it from
   whichever module calls `ensure_current`, however that would be incorrect, as
   the two modules don't actually share the same `Db` handle objects, so they do
   need to re-read the most recent key.
   
   Ideally we'd implement a single `couch_fdb` module to be shared between
   `couch_jobs` and `fabric2_db` but until then it maybe simpler to just let
   `couch_jobs` use its own metadata key. This way, it doesn't get invalidated or
   bumped every time dbs get recreated or design docs are updated. The only time
   it would be bumped is if the FDB layer prefix changed at runtime.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] garrensmith merged pull request #2569: Let couch_jobs use its own metadata key

[GitBox <gi...@apache.org>]

garrensmith merged pull request #2569: Let couch_jobs use its own metadata key
URL: https://github.com/apache/couchdb/pull/2569
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] nickva commented on issue #2569: Let couch_jobs use its own metadata key

[GitBox <gi...@apache.org>]

nickva commented on issue #2569: Let couch_jobs use its own metadata key
URL: https://github.com/apache/couchdb/pull/2569#issuecomment-587949493
 
 
   Test with `make eunit apps=fabric,couch_jobs,couch_views`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services