Re: svn commit: r1463721 - in /subversion/trunk/subversion/libsvn_client: checkout.c client.h commit.c copy.c export.c externals.c revert.c switch.c update.c

[Philip Martin <ph...@wandisco.com>]

julianfoad@apache.org writes:

> Author: julianfoad
> Date: Tue Apr  2 19:53:43 2013
> New Revision: 1463721
> after releasing it in other places.  We should pick one and be consistent.

> --- subversion/trunk/subversion/libsvn_client/commit.c (original)
> +++ subversion/trunk/subversion/libsvn_client/commit.c Tue Apr  2 19:53:43 2013
> @@ -985,10 +985,11 @@ svn_client_commit6(const apr_array_heade
>                     iterpool);
>      }
>  
> + cleanup:
>    /* Sleep to ensure timestamp integrity. */
> -  svn_io_sleep_for_timestamps(base_abspath, pool);
> +  if (commit_in_progress)
> +    svn_io_sleep_for_timestamps(base_abspath, pool);

This bit doesn't look right.  commit_in_progress is set back to FALSE
before post-commit processing so as far as I can see a successful commit
no longer sleeps.  This ould explain the buildbot failures
http://ci.apache.org/builders/svn-x64-centos-gcc/builds/9039

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download

Re: svn commit: r1463721 - in /subversion/trunk/subversion/libsvn_client: checkout.c client.h commit.c copy.c export.c externals.c revert.c switch.c update.c

[Julian Foad <ju...@btopenworld.com>]

Philip Martin wrote:

>>  + cleanup:
>>     /* Sleep to ensure timestamp integrity. */
>>  -  svn_io_sleep_for_timestamps(base_abspath, pool);
>>  +  if (commit_in_progress)
>>  +    svn_io_sleep_for_timestamps(base_abspath, pool);
> 
> This bit doesn't look right.  commit_in_progress is set back to FALSE
> before post-commit processing so as far as I can see a successful commit
> no longer sleeps.  This ould explain the buildbot failures
> http://ci.apache.org/builders/svn-x64-centos-gcc/builds/9039

Thanks for catching this.  I hadn't noticed the  "commit_in_progress = FALSE".  Will fix.

r1463803.  Hope that does it.

- Julian