You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/07 11:12:15 UTC

[GitHub] [arrow-datafusion] mkmik commented on pull request #1747: fix: Case insensitive unquoted identifiers in SQL

mkmik commented on pull request #1747:
URL: https://github.com/apache/arrow-datafusion/pull/1747#issuecomment-1031348601


   @alamb thanks; I factored out the normalization step in a utility function and called it from a few more places.
   
   I added tests that cover all of the column references I can think of (e.g. aliases, order by, where, group by). I wouldn't be surprised if I missed some, but perhaps we can treat such cases as new bugs.
   
   I specifically didn't cover table name reference normalization here and instead opened #1771 to track that.
   
   PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org