You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/06/04 08:44:00 UTC
Review Request 35051: DRILL-2089: Part 6--Rename
DrillPreparedStatement to ...Impl. [various]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35051/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2089
https://issues.apache.org/jira/browse/DRILL-2089
Repository: drill-git
Description
-------
Renamed DrillPreparedStatement to DrillPreparedStatementImpl (because name "DrillPreparedStatement" is reserved for Drill subinterface of PreparedStatement).
Diffs
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION
Diff: https://reviews.apache.org/r/35051/diff/
Testing
-------
Ran existing tests. (With parts 1 through 7 together.)
Thanks,
Daniel Barclay
Re: Review Request 35051: DRILL-2089: Part 6--Rename
DrillPreparedStatement to ...Impl. [various]
Posted by Daniel Barclay <db...@maprtech.com>.
> On June 9, 2015, 9:02 p.m., Parth Chandra wrote:
> > Same comment as previous review about removing empty files.
Same reply re checking/re-making/re-uploading patch and base patch.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35051/#review87296
-----------------------------------------------------------
On June 9, 2015, 10:10 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35051/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 10:10 p.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2089
> https://issues.apache.org/jira/browse/DRILL-2089
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Renamed DrillPreparedStatement to DrillPreparedStatementImpl (because name "DrillPreparedStatement" is reserved for Drill subinterface of PreparedStatement).
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35051/diff/
>
>
> Testing
> -------
>
> Ran existing tests. (With parts 1 through 7 together.)
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 35051: DRILL-2089: Part 6--Rename
DrillPreparedStatement to ...Impl. [various]
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35051/#review87296
-----------------------------------------------------------
Ship it!
Same comment as previous review about removing empty files.
- Parth Chandra
On June 4, 2015, 6:43 a.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35051/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 6:43 a.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2089
> https://issues.apache.org/jira/browse/DRILL-2089
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Renamed DrillPreparedStatement to DrillPreparedStatementImpl (because name "DrillPreparedStatement" is reserved for Drill subinterface of PreparedStatement).
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35051/diff/
>
>
> Testing
> -------
>
> Ran existing tests. (With parts 1 through 7 together.)
>
>
> Thanks,
>
> Daniel Barclay
>
>
Re: Review Request 35051: DRILL-2089: Part 6--Rename
DrillPreparedStatement to ...Impl. [various]
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35051/
-----------------------------------------------------------
(Updated June 16, 2015, 1:53 a.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2089
https://issues.apache.org/jira/browse/DRILL-2089
Repository: drill-git
Description
-------
Renamed DrillPreparedStatement to DrillPreparedStatementImpl (because name "DrillPreparedStatement" is reserved for Drill subinterface of PreparedStatement).
Diffs (updated)
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION
Diff: https://reviews.apache.org/r/35051/diff/
Testing
-------
Ran existing tests. (With parts 1 through 7 together.)
Thanks,
Daniel Barclay
Re: Review Request 35051: DRILL-2089: Part 6--Rename
DrillPreparedStatement to ...Impl. [various]
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35051/
-----------------------------------------------------------
(Updated June 16, 2015, 1:48 a.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
Re-uploading patches, trying to fix/work around Review Board empty-files problem.
Bugs: DRILL-2089
https://issues.apache.org/jira/browse/DRILL-2089
Repository: drill-git
Description
-------
Renamed DrillPreparedStatement to DrillPreparedStatementImpl (because name "DrillPreparedStatement" is reserved for Drill subinterface of PreparedStatement).
Diffs (updated)
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java 78356c9
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION
Diff: https://reviews.apache.org/r/35051/diff/
Testing
-------
Ran existing tests. (With parts 1 through 7 together.)
Thanks,
Daniel Barclay
Re: Review Request 35051: DRILL-2089: Part 6--Rename
DrillPreparedStatement to ...Impl. [various]
Posted by Daniel Barclay <db...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35051/
-----------------------------------------------------------
(Updated June 9, 2015, 10:10 p.m.)
Review request for drill, Mehant Baid and Parth Chandra.
Changes
-------
Re-uploaded base patch to fix changed files that showed up as empty.
Bugs: DRILL-2089
https://issues.apache.org/jira/browse/DRILL-2089
Repository: drill-git
Description
-------
Renamed DrillPreparedStatement to DrillPreparedStatementImpl (because name "DrillPreparedStatement" is reserved for Drill subinterface of PreparedStatement).
Diffs (updated)
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillJdbc41Factory.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java PRE-CREATION
Diff: https://reviews.apache.org/r/35051/diff/
Testing
-------
Ran existing tests. (With parts 1 through 7 together.)
Thanks,
Daniel Barclay