You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/15 11:44:49 UTC

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4645: Make OptimizerConfig a trait (#4631) (#4638)

tustvold commented on code in PR #4645:
URL: https://github.com/apache/arrow-datafusion/pull/4645#discussion_r1049540588


##########
datafusion/core/src/execution/context.rs:
##########
@@ -1557,14 +1557,6 @@ impl SessionState {
                 .register_catalog(config.default_catalog.clone(), default_catalog);
         }
 
-        let optimizer_config = OptimizerConfig::new().filter_null_keys(

Review Comment:
   Moving this into the `OptimizerConfig` passed at optimize time is the fix for #4638 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org