[GitHub] [airflow] mik-laj commented on a change in pull request #8218: CSS linting integrated into pre-commit

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #8218: CSS linting integrated into pre-commit
URL: https://github.com/apache/airflow/pull/8218#discussion_r405799056
 
 

 ##########
 File path: .pre-commit-config.yaml
 ##########
 @@ -360,3 +360,8 @@ repos:
         entry: "./scripts/ci/pre_commit_bat_tests.sh"
         files: ^breeze$|^breeze-complete$|\.sh$|\.bash$
         pass_filenames: false
+      - id: stylelint
+        name: stylelint
+        entry: "stylelint"
+        language: node
+        files: ^airflow/www/.*\.(css|scss|sass)$
 
 Review comment:
   ```suggestion
           files: ^airflow/www/.*\.(css|scss|sass)$
           additional_dependencies: ["stylelint@13.3.0"]
   ```
   This should also work. Please look at the example:  https://github.com/pre-commit/mirrors-eslint/blob/master/.pre-commit-hooks.yaml
   
   You can also use: https://github.com/awebdeveloper/pre-commit-stylelint
   
   I don't know which solution is better, but downloading a large image with the system for one simple application can be expensive. I suspect that there is no one common base image for all pre-commit hooks.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services