You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/12/20 23:14:48 UTC
[GitHub] [kylin] etherge opened a new pull request #1012: KYLIN-4311 fix
noncompliant interator issue in sonar
etherge opened a new pull request #1012: KYLIN-4311 fix noncompliant interator issue in sonar
URL: https://github.com/apache/kylin/pull/1012
JIRA: https://issues.apache.org/jira/browse/KYLIN-4311
By contract, any implementation of the java.util.Iterator.next() method should throw a NoSuchElementException exception when the iteration has no more elements. Any other behavior when the iteration is done could lead to unexpected behavior for users of this Iterator.
https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWExwNw9ikuHJGLsvan_&open=AWExwNw9ikuHJGLsvan_
https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWExwNxOikuHJGLsvaoZ&open=AWExwNxOikuHJGLsvaoZ
https://sonarcloud.io/project/issues?id=org.apache.kylin%3Akylin&issues=AWExwOHQikuHJGLsvbDO&open=AWExwOHQikuHJGLsvbDO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1012: KYLIN-4311 fix
noncompliant interator issue in sonar
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1012: KYLIN-4311 fix noncompliant interator issue in sonar
URL: https://github.com/apache/kylin/pull/1012#issuecomment-568125863
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1012?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@09cc5a2`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/1012?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1012 +/- ##
=========================================
Coverage ? 25.45%
Complexity ? 6178
=========================================
Files ? 1418
Lines ? 86057
Branches ? 12072
=========================================
Hits ? 21902
Misses ? 62015
Partials ? 2140
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1012?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...in/storage/hbase/cube/v2/ExpectedSizeIterator.java](https://codecov.io/gh/apache/kylin/pull/1012/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9jdWJlL3YyL0V4cGVjdGVkU2l6ZUl0ZXJhdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../org/apache/kylin/common/util/ImmutableBitSet.java](https://codecov.io/gh/apache/kylin/pull/1012/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0ltbXV0YWJsZUJpdFNldC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/1012/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `72% <0%> (ø)` | `8 <0> (?)` | |
| [...ava/org/apache/kylin/common/util/FIFOIterator.java](https://codecov.io/gh/apache/kylin/pull/1012/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0ZJRk9JdGVyYXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1012?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1012?src=pr&el=footer). Last update [09cc5a2...37b1331](https://codecov.io/gh/apache/kylin/pull/1012?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1012: KYLIN-4311 fix
noncompliant interator issue in sonar
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1012: KYLIN-4311 fix noncompliant interator issue in sonar
URL: https://github.com/apache/kylin/pull/1012
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services