You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "ocket8888 (via GitHub)" <gi...@apache.org> on 2023/03/24 15:32:16 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7421: TPv2 API services tech debt
ocket8888 opened a new pull request, #7421:
URL: https://github.com/apache/trafficcontrol/pull/7421
This PR adds 100% test coverage to the API services in TPv2, primarily. It also adds an overload signature or two, some overload JSDoc comments, and fixes a couple bugs I encountered while writing the tests.
<hr/>
## Which Traffic Control components are affected by this PR?
- Traffic Portal (experimental v2)
## What is the best way to verify this PR?
Make sure the new unit tests pass. Verify 100% coverage with `ng test --code-coverage` (note the testing services have no such promise of coverage (yet)).
## PR submission checklist
- [x] This PR has tests
- [x] This PR has documentation
- [x] This PR doesn't need a CHANGELOG.md entry
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7421: TPv2 API services tech debt
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7421:
URL: https://github.com/apache/trafficcontrol/pull/7421#issuecomment-1528020991
## [Codecov](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7421](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (680c102) into [master](https://codecov.io/gh/apache/trafficcontrol/commit/39f4019e735d2c648304d66376bac73b0c96f97d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39f4019) will **increase** coverage by `4.32%`.
> The diff coverage is `98.37%`.
```diff
@@ Coverage Diff @@
## master #7421 +/- ##
============================================
+ Coverage 61.11% 65.44% +4.32%
Complexity 98 98
============================================
Files 305 305
Lines 11674 11616 -58
Branches 795 788 -7
============================================
+ Hits 7135 7602 +467
+ Misses 4191 3667 -524
+ Partials 348 347 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| traffic_portal_v2 | `76.44% <98.37%> (+12.13%)` | :arrow_up: |
| unit_tests | `76.44% <98.37%> (+12.13%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...traffic-portal/src/app/api/testing/user.service.ts](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhwZXJpbWVudGFsL3RyYWZmaWMtcG9ydGFsL3NyYy9hcHAvYXBpL3Rlc3RpbmcvdXNlci5zZXJ2aWNlLnRz) | `46.87% <0.00%> (+1.68%)` | :arrow_up: |
| [...tal/traffic-portal/src/app/api/base-api.service.ts](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhwZXJpbWVudGFsL3RyYWZmaWMtcG9ydGFsL3NyYy9hcHAvYXBpL2Jhc2UtYXBpLnNlcnZpY2UudHM=) | `100.00% <100.00%> (+41.17%)` | :arrow_up: |
| [.../traffic-portal/src/app/api/cache-group.service.ts](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhwZXJpbWVudGFsL3RyYWZmaWMtcG9ydGFsL3NyYy9hcHAvYXBpL2NhY2hlLWdyb3VwLnNlcnZpY2UudHM=) | `100.00% <100.00%> (+99.09%)` | :arrow_up: |
| [...rimental/traffic-portal/src/app/api/cdn.service.ts](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhwZXJpbWVudGFsL3RyYWZmaWMtcG9ydGFsL3NyYy9hcHAvYXBpL2Nkbi5zZXJ2aWNlLnRz) | `100.00% <100.00%> (+96.00%)` | :arrow_up: |
| [.../traffic-portal/src/app/api/change-logs.service.ts](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhwZXJpbWVudGFsL3RyYWZmaWMtcG9ydGFsL3NyYy9hcHAvYXBpL2NoYW5nZS1sb2dzLnNlcnZpY2UudHM=) | `100.00% <100.00%> (+80.00%)` | :arrow_up: |
| [...fic-portal/src/app/api/delivery-service.service.ts](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhwZXJpbWVudGFsL3RyYWZmaWMtcG9ydGFsL3NyYy9hcHAvYXBpL2RlbGl2ZXJ5LXNlcnZpY2Uuc2VydmljZS50cw==) | `100.00% <100.00%> (+99.20%)` | :arrow_up: |
| [...fic-portal/src/app/api/invalidation-job.service.ts](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhwZXJpbWVudGFsL3RyYWZmaWMtcG9ydGFsL3NyYy9hcHAvYXBpL2ludmFsaWRhdGlvbi1qb2Iuc2VydmljZS50cw==) | `100.00% <100.00%> (+96.00%)` | :arrow_up: |
| [...ic-portal/src/app/api/physical-location.service.ts](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhwZXJpbWVudGFsL3RyYWZmaWMtcG9ydGFsL3NyYy9hcHAvYXBpL3BoeXNpY2FsLWxvY2F0aW9uLnNlcnZpY2UudHM=) | `100.00% <100.00%> (+95.23%)` | :arrow_up: |
| [...ntal/traffic-portal/src/app/api/profile.service.ts](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhwZXJpbWVudGFsL3RyYWZmaWMtcG9ydGFsL3NyYy9hcHAvYXBpL3Byb2ZpbGUuc2VydmljZS50cw==) | `100.00% <100.00%> (+94.44%)` | :arrow_up: |
| [...ental/traffic-portal/src/app/api/server.service.ts](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXhwZXJpbWVudGFsL3RyYWZmaWMtcG9ydGFsL3NyYy9hcHAvYXBpL3NlcnZlci5zZXJ2aWNlLnRz) | `100.00% <100.00%> (+98.48%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/trafficcontrol/pull/7421?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [2 files with indirect coverage changes](https://codecov.io/gh/apache/trafficcontrol/pull/7421/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus merged pull request #7421: TPv2 API services tech debt
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus merged PR #7421:
URL: https://github.com/apache/trafficcontrol/pull/7421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on pull request #7421: TPv2 API services tech debt
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus commented on PR #7421:
URL: https://github.com/apache/trafficcontrol/pull/7421#issuecomment-1507205294
This will need to be rebased as next time the E2E tests will fail due to chrome version mismatch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org