You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/08/14 09:12:44 UTC

[GitHub] [orc] wgtmac opened a new issue, #1583: Release Apache ORC 1.8.5

wgtmac opened a new issue, #1583:
URL: https://github.com/apache/orc/issues/1583

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac commented on issue #1583: Release Apache ORC 1.8.5

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1700253721

   Thanks @guiyanakuang and @dongjoon-hyun! Let me try to increase the memory and run them one by one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] guiyanakuang commented on issue #1583: Release Apache ORC 1.8.5

Posted by "guiyanakuang (via GitHub)" <gi...@apache.org>.
guiyanakuang commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1699536327

   I was running the command on the branch-1.8. Judging from the error, it may be that the memory allocated by docker is insufficient.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on issue #1583: Release Apache ORC 1.8.5

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1699527575

   Hi, @wgtmac . You need to`reinit` the OS image first inside `branch-1.8`.
   ```
   $ ./reinit.sh
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac commented on issue #1583: Release Apache ORC 1.8.5

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1699487946

   It seems that I have a lot of issues running the docker test on the branch-1.8.
   
   ```
   tail -n10 logs/*test*
   ==> logs/centos7-test.log <==
   [INFO] No dependency problems found
   [INFO]
   [INFO] --- maven-assembly-plugin:3.4.1:single (make-assembly) @ orc-benchmarks-hive ---
   [INFO] Reading assembly descriptor: src/assembly/uber.xml
   ./mvnw: line 102:  5650 Killed                  "${MVN_BIN}" "$@"
   make[2]: *** [java/CMakeFiles/java_build.dir/build.make:64: java/shims/orc-shims-1.8.5-SNAPSHOT.jar] Error 137
   make[2]: *** Deleting file 'java/shims/orc-shims-1.8.5-SNAPSHOT.jar'
   make[1]: *** [CMakeFiles/Makefile2:591: java/CMakeFiles/java_build.dir/all] Error 2
   make: *** [Makefile:163: all] Error 2
   FAILED centos7
   
   ==> logs/debian10-test.log <==
   [ 70%] Building CXX object lib/fs/CMakeFiles/fs_obj.dir/filesystem_sync.cc.o
   c++: fatal error: Killed signal terminated program cc1plus
   compilation terminated.
   make[5]: *** [lib/fs/CMakeFiles/fs_obj.dir/build.make:76: lib/fs/CMakeFiles/fs_obj.dir/filesystem_sync.cc.o] Error 1
   make[4]: *** [CMakeFiles/Makefile2:1421: lib/fs/CMakeFiles/fs_obj.dir/all] Error 2
   make[3]: *** [Makefile:141: all] Error 2
   make[2]: *** [CMakeFiles/libhdfspp_ep.dir/build.make:113: libhdfspp_ep-prefix/src/libhdfspp_ep-stamp/libhdfspp_ep-build] Error 2
   make[1]: *** [CMakeFiles/Makefile2:295: CMakeFiles/libhdfspp_ep.dir/all] Error 2
   make: *** [Makefile:163: all] Error 2
   FAILED debian10
   
   ==> logs/debian10_jdk=11-test.log <==
   [INFO] Executed tasks
   [INFO]
   [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ orc-core ---
   [INFO] Compiling 93 source files to /root/build/java/core/test-classes
   ./mvnw: line 102:  6730 Killed                  "${MVN_BIN}" "$@"
   make[2]: *** [java/CMakeFiles/java_build.dir/build.make:64: java/shims/orc-shims-1.8.5-SNAPSHOT.jar] Error 137
   make[2]: *** Deleting file 'java/shims/orc-shims-1.8.5-SNAPSHOT.jar'
   make[1]: *** [CMakeFiles/Makefile2:591: java/CMakeFiles/java_build.dir/all] Error 2
   make: *** [Makefile:163: all] Error 2
   FAILED debian10_jdk=11
   
   ==> logs/debian11-test.log <==
   [ 21%] Building CXX object lib/proto/CMakeFiles/proto_obj.dir/ClientNamenodeProtocol.pb.cc.o
   c++: fatal error: Killed signal terminated program cc1plus
   compilation terminated.
   make[5]: *** [lib/proto/CMakeFiles/proto_obj.dir/build.make:218: lib/proto/CMakeFiles/proto_obj.dir/ClientNamenodeProtocol.pb.cc.o] Error 1
   make[4]: *** [CMakeFiles/Makefile2:1537: lib/proto/CMakeFiles/proto_obj.dir/all] Error 2
   make[3]: *** [Makefile:160: all] Error 2
   make[2]: *** [CMakeFiles/libhdfspp_ep.dir/build.make:132: libhdfspp_ep-prefix/src/libhdfspp_ep-stamp/libhdfspp_ep-build] Error 2
   make[1]: *** [CMakeFiles/Makefile2:447: CMakeFiles/libhdfspp_ep.dir/all] Error 2
   make: *** [Makefile:182: all] Error 2
   FAILED debian11
   
   ==> logs/fedora37-test.log <==
   [ 21%] Building CXX object lib/proto/CMakeFiles/proto_obj.dir/ClientNamenodeProtocol.pb.cc.o
   c++: fatal error: Killed signal terminated program cc1plus
   compilation terminated.
   make[5]: *** [lib/proto/CMakeFiles/proto_obj.dir/build.make:214: lib/proto/CMakeFiles/proto_obj.dir/ClientNamenodeProtocol.pb.cc.o] Error 1
   make[4]: *** [CMakeFiles/Makefile2:1449: lib/proto/CMakeFiles/proto_obj.dir/all] Error 2
   make[3]: *** [Makefile:146: all] Error 2
   make[2]: *** [CMakeFiles/libhdfspp_ep.dir/build.make:86: libhdfspp_ep-prefix/src/libhdfspp_ep-stamp/libhdfspp_ep-build] Error 2
   make[1]: *** [CMakeFiles/Makefile2:405: CMakeFiles/libhdfspp_ep.dir/all] Error 2
   make: *** [Makefile:166: all] Error 2
   FAILED fedora37
   
   ==> logs/ubuntu18-test.log <==
   [INFO] Excluding org.slf4j:slf4j-simple:jar:1.7.36 from the shaded jar.
   ./mvnw: line 102:  6626 Killed                  "${MVN_BIN}" "$@"
   make[2]: *** [java/shims/orc-shims-1.8.5-SNAPSHOT.jar] Error 137
   java/CMakeFiles/java_build.dir/build.make:63: recipe for target 'java/shims/orc-shims-1.8.5-SNAPSHOT.jar' failed
   make[2]: *** Deleting file 'java/shims/orc-shims-1.8.5-SNAPSHOT.jar'
   CMakeFiles/Makefile2:585: recipe for target 'java/CMakeFiles/java_build.dir/all' failed
   make[1]: *** [java/CMakeFiles/java_build.dir/all] Error 2
   Makefile:162: recipe for target 'all' failed
   make: *** [all] Error 2
   FAILED ubuntu18
   
   ==> logs/ubuntu20-test.log <==
   [INFO]
   [INFO] --- maven-assembly-plugin:3.4.1:single (make-assembly) @ orc-benchmarks-core ---
   [INFO] Reading assembly descriptor: src/assembly/uber.xml
   [INFO] Building jar: /root/build/java/bench/core/orc-benchmarks-core-1.8.5-SNAPSHOT-uber.jar
   ./mvnw: line 102:  6008 Killed                  "${MVN_BIN}" "$@"
   make[2]: *** [java/CMakeFiles/java_build.dir/build.make:64: java/shims/orc-shims-1.8.5-SNAPSHOT.jar] Error 137
   make[2]: *** Deleting file 'java/shims/orc-shims-1.8.5-SNAPSHOT.jar'
   make[1]: *** [CMakeFiles/Makefile2:581: java/CMakeFiles/java_build.dir/all] Error 2
   make: *** [Makefile:163: all] Error 2
   FAILED ubuntu20
   
   ==> logs/ubuntu20_jdk=11-test.log <==
   [INFO] Including org.tukaani:xz:jar:1.9 in the shaded jar.
   [INFO] Including org.jodd:jodd-core:jar:3.5.2 in the shaded jar.
   [INFO] Including org.openjdk.jmh:jmh-core:jar:1.20 in the shaded jar.
   [INFO] Including net.sf.jopt-simple:jopt-simple:jar:4.6 in the shaded jar.
   [INFO] Including org.openjdk.jmh:jmh-generator-annprocess:jar:1.20 in the shaded jar.
   [INFO] Including org.scala-lang:scala-library:jar:2.12.15 in the shaded jar.
   [INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.14.2 in the shaded jar.
   [INFO] Including com.fasterxml.jackson.core:jackson-databind:jar:2.14.2 in the shaded jar.
   [INFO] Including com.fasterxml.jackson.core:jackson-annotations:jar:2.14.2 in the shaded jar.
   [INFO] Including org.objenesis:objenesis:jar:3.2 in the shaded jar.
   
   ==> logs/ubuntu20_jdk=11_cc=clang-test.log <==
         value = readByte();
               ~ ^~~~~~~~~~
   /root/orc/c++/src/ByteRLE.cc:469:36: error: implicit conversion changes signedness: 'signed char' to 'char' [-Werror,-Wsign-conversion]
                 data[position + i] = readByte();
                                    ~ ^~~~~~~~~~
   3 errors generated.
   make[2]: *** [c++/src/CMakeFiles/orc.dir/build.make:213: c++/src/CMakeFiles/orc.dir/ByteRLE.cc.o] Error 1
   make[1]: *** [CMakeFiles/Makefile2:487: c++/src/CMakeFiles/orc.dir/all] Error 2
   make: *** [Makefile:163: all] Error 2
   FAILED ubuntu20_jdk=11_cc=clang
   
   ==> logs/ubuntu22-test.log <==
   [ 21%] Building CXX object lib/proto/CMakeFiles/proto_obj.dir/ClientNamenodeProtocol.pb.cc.o
   c++: fatal error: Killed signal terminated program cc1plus
   compilation terminated.
   make[5]: *** [lib/proto/CMakeFiles/proto_obj.dir/build.make:214: lib/proto/CMakeFiles/proto_obj.dir/ClientNamenodeProtocol.pb.cc.o] Error 1
   make[4]: *** [CMakeFiles/Makefile2:1449: lib/proto/CMakeFiles/proto_obj.dir/all] Error 2
   make[3]: *** [Makefile:146: all] Error 2
   make[2]: *** [CMakeFiles/libhdfspp_ep.dir/build.make:86: libhdfspp_ep-prefix/src/libhdfspp_ep-stamp/libhdfspp_ep-build] Error 2
   make[1]: *** [CMakeFiles/Makefile2:405: CMakeFiles/libhdfspp_ep.dir/all] Error 2
   make: *** [Makefile:166: all] Error 2
   FAILED ubuntu22
   ```
   
   @guiyanakuang I see you have used `./run-all.sh apache branch-1.8` to run the docker test for the 1.8.4 release. Was the run-all.sh script on the branch-1.8 or main branch?
   
   cc @dongjoon-hyun if you have any advise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on issue #1583: Release Apache ORC 1.8.5

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1699538109

   If then, you can increase the memory because the all OSes run at the same time. I'd recommend that.
   Or, run one by one via `run-one.sh`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on issue #1583: Release Apache ORC 1.8.5

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1686774917

   Also, cc @williamhyun .
   
   If there is no community need to release v1.8.5 now, we can delay the due date of this milestone .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on issue #1583: Release Apache ORC 1.8.5

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1686773760

   Thank you, @wgtmac . 
   
   BTW, it seems that there is no new commit in branch-1.8 since v1.8.4 (@guiyanakuang )
   - https://github.com/apache/orc/commits/branch-1.8
   - https://github.com/apache/orc/milestone/21?closed=1
   
   Do you want to backport some?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac commented on issue #1583: Release Apache ORC 1.8.5

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1690173550

   After a rough check, I didn't see any commit that worth backporting (bug fix or minor improvement). So I suggest to delay the release if this does not change till the due date. @dongjoon-hyun @williamhyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac commented on issue #1583: Release Apache ORC 1.8.5

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1687328502

   Yes, I have noticed the same thing. Let me spend some time to see if there is anything required to backport. @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on issue #1583: Release Apache ORC 1.8.5

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1690206743

   Got it. +1 for your decision, @wgtmac .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on issue #1583: Release Apache ORC 1.8.5

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1711819489

   Thank you again, @wgtmac . Since this is done, let me close this issue too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] wgtmac commented on issue #1583: Release Apache ORC 1.8.5

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1700235186

   > BTW, for me, it looks like a dev environment issue exists a the same time.
   > 
   > ```
   > ==> logs/ubuntu20_jdk=11_cc=clang-test.log <==
   > /root/orc/c++/src/ByteRLE.cc:469:36: error: implicit conversion changes signedness: 'signed char' to 'char' [-Werror,-Wsign-conversion]
   >               data[position + i] = readByte();
   >                                  ~ ^~~~~~~~~~
   > ```
   
   I agree. I think we need to backport https://github.com/apache/orc/commit/acb8d6cad138a8fc629053d487b55017d148ff9d


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun closed issue #1583: Release Apache ORC 1.8.5

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed issue #1583: Release Apache ORC 1.8.5
URL: https://github.com/apache/orc/issues/1583


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [orc] dongjoon-hyun commented on issue #1583: Release Apache ORC 1.8.5

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on issue #1583:
URL: https://github.com/apache/orc/issues/1583#issuecomment-1699539279

   BTW, for me, it looks like a dev environment issue.
   ```
   /root/orc/c++/src/ByteRLE.cc:469:36: error: implicit conversion changes signedness: 'signed char' to 'char' [-Werror,-Wsign-conversion]
                 data[position + i] = readByte();
                                    ~ ^~~~~~~~~~
   /root/orc/c++/src/ByteRLE.cc:469:36: error: implicit conversion changes signedness: 'signed char' to 'char' [-Werror,-Wsign-conversion]
                 data[position + i] = readByte();
                                    ~ ^~~~~~~~~~
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org