[GitHub] [hadoop-ozone] elek commented on a change in pull request #1387: HDDS-4198. Compile Ozone with multiple Java versions

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #1387:
URL: https://github.com/apache/hadoop-ozone/pull/1387#discussion_r483529467



##########
File path: hadoop-ozone/dev-support/checks/build.sh
##########
@@ -17,5 +17,5 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
 cd "$DIR/../../.." || exit 1
 
 export MAVEN_OPTS="-Xmx4096m"
-mvn -B -Dmaven.javadoc.skip=true -DskipTests clean install "$@"
+mvn -V -B -Dmaven.javadoc.skip=true -DskipTests clean install "$@"

Review comment:
       `-V` --> very nice, never used this flag #TIL 

##########
File path: .github/workflows/post-commit.yml
##########
@@ -34,10 +38,17 @@ jobs:
           key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
           restore-keys: |
             ${{ runner.os }}-pnpm-
-      - name: Execute tests
-        uses: ./.github/buildenv
+      - name: Cache for maven dependencies
+        uses: actions/cache@v2
         with:
-          args: ./hadoop-ozone/dev-support/checks/build.sh

Review comment:
       We can consider doing the same with all the other steps.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org