You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/02/06 10:50:42 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1702: Fix bug: Use try-with-resources or close this "Statement" in a
"finally" clause.
codecov-io edited a comment on issue #1702: Fix bug: Use try-with-resources or close this "Statement" in a "finally" clause.
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1702#issuecomment-570578752
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702?src=pr&el=h1) Report
> Merging [#1702](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/0a3954107eb5df95383b844874beb5bf0da7c878?src=pr&el=desc) will **increase** coverage by `6.5%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1702 +/- ##
=========================================
+ Coverage 17.15% 23.66% +6.5%
=========================================
Files 285 299 +14
Lines 13900 14405 +505
Branches 2267 2374 +107
=========================================
+ Hits 2385 3409 +1024
+ Misses 11240 10605 -635
- Partials 275 391 +116
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he/dolphinscheduler/common/utils/ScriptRunner.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1NjcmlwdFJ1bm5lci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...phinscheduler/common/enums/HttpCheckCondition.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0h0dHBDaGVja0NvbmRpdGlvbi5qYXZh) | `0% <0%> (-100%)` | :arrow_down: |
| [...ache/dolphinscheduler/common/enums/HttpMethod.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0h0dHBNZXRob2QuamF2YQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...che/dolphinscheduler/common/enums/ProgramType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Byb2dyYW1UeXBlLmphdmE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...hinscheduler/common/utils/TaskParametersUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1Rhc2tQYXJhbWV0ZXJzVXRpbHMuamF2YQ==) | `0% <0%> (-93.75%)` | :arrow_down: |
| [...apache/dolphinscheduler/common/enums/TaskType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Rhc2tUeXBlLmphdmE=) | `0% <0%> (-84.62%)` | :arrow_down: |
| [...che/dolphinscheduler/common/utils/SchemaUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1NjaGVtYVV0aWxzLmphdmE=) | `0% <0%> (-71.43%)` | :arrow_down: |
| [...phinscheduler/common/task/http/HttpParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svaHR0cC9IdHRwUGFyYW1ldGVycy5qYXZh) | `0% <0%> (-50%)` | :arrow_down: |
| [...pache/dolphinscheduler/common/utils/FileUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0ZpbGVVdGlscy5qYXZh) | `3.26% <0%> (-38.05%)` | :arrow_down: |
| [...pache/dolphinscheduler/common/utils/EnumUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0VudW1VdGlscy5qYXZh) | `0% <0%> (-27.28%)` | :arrow_down: |
| ... and [141 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702?src=pr&el=footer). Last update [0a39541...c2a8371](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1702?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services