You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Chris Morgan (JIRA)" <ji...@apache.org> on 2011/02/07 18:58:57 UTC

[jira] Created: (THRIFT-1054) explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail

explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail
--------------------------------------------------------------------------------------------------------------------------------

                 Key: THRIFT-1054
                 URL: https://issues.apache.org/jira/browse/THRIFT-1054
             Project: Thrift
          Issue Type: Bug
    Affects Versions: 0.7
         Environment: Kubuntu 10.10 (Maverick)
            Reporter: Chris Morgan


>From aclocal.m4:

# Note that if there is a possibility the first call to
# PKG_CHECK_MODULES might not happen, you should be sure to include an
# explicit call to PKG_PROG_PKG_CONFIG in your configure.ac

I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call is missed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it.

The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (THRIFT-1054) explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-1054.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.7
         Assignee: Chris Morgan  (was: Bryan Duxbury)

I just committed this.

> explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1054
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1054
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Kubuntu 10.10 (Maverick)
>            Reporter: Chris Morgan
>            Assignee: Chris Morgan
>             Fix For: 0.7
>
>         Attachments: configure_ac_pkg_config_check.patch
>
>
> From aclocal.m4:
> {code}
> # Note that if there is a possibility the first call to
> # PKG_CHECK_MODULES might not happen, you should be sure to include an
> # explicit call to PKG_PROG_PKG_CONFIG in your configure.ac
> {code}
> I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call isn't always executed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it. aclocal.m4 warns against this situation and proposes calling PKG_PROG_PKG_CONFIG.
> The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (THRIFT-1054) explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992084#comment-12992084 ] 

David Reiss commented on THRIFT-1054:
-------------------------------------

Fine with me.

> explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1054
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1054
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Kubuntu 10.10 (Maverick)
>            Reporter: Chris Morgan
>            Assignee: Bryan Duxbury
>         Attachments: configure_ac_pkg_config_check.patch
>
>
> From aclocal.m4:
> {code}
> # Note that if there is a possibility the first call to
> # PKG_CHECK_MODULES might not happen, you should be sure to include an
> # explicit call to PKG_PROG_PKG_CONFIG in your configure.ac
> {code}
> I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call isn't always executed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it. aclocal.m4 warns against this situation and proposes calling PKG_PROG_PKG_CONFIG.
> The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (THRIFT-1054) explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated THRIFT-1054:
----------------------------------

    Description: 
>From aclocal.m4:
{code}
# Note that if there is a possibility the first call to
# PKG_CHECK_MODULES might not happen, you should be sure to include an
# explicit call to PKG_PROG_PKG_CONFIG in your configure.ac
{code}
I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call isn't always executed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it. aclocal.m4 warns against this situation and proposes calling PKG_PROG_PKG_CONFIG.

The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac

  was:
>From aclocal.m4:

# Note that if there is a possibility the first call to
# PKG_CHECK_MODULES might not happen, you should be sure to include an
# explicit call to PKG_PROG_PKG_CONFIG in your configure.ac

I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call isn't always executed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it. aclocal.m4 warns against this situation and proposes calling PKG_PROG_PKG_CONFIG.

The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac


> explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1054
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1054
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Kubuntu 10.10 (Maverick)
>            Reporter: Chris Morgan
>            Assignee: Bryan Duxbury
>         Attachments: configure_ac_pkg_config_check.patch
>
>
> From aclocal.m4:
> {code}
> # Note that if there is a possibility the first call to
> # PKG_CHECK_MODULES might not happen, you should be sure to include an
> # explicit call to PKG_PROG_PKG_CONFIG in your configure.ac
> {code}
> I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call isn't always executed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it. aclocal.m4 warns against this situation and proposes calling PKG_PROG_PKG_CONFIG.
> The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (THRIFT-1054) explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury reassigned THRIFT-1054:
-------------------------------------

    Assignee: Bryan Duxbury

> explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1054
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1054
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Kubuntu 10.10 (Maverick)
>            Reporter: Chris Morgan
>            Assignee: Bryan Duxbury
>         Attachments: configure_ac_pkg_config_check.patch
>
>
> From aclocal.m4:
> # Note that if there is a possibility the first call to
> # PKG_CHECK_MODULES might not happen, you should be sure to include an
> # explicit call to PKG_PROG_PKG_CONFIG in your configure.ac
> I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call is missed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it.
> The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (THRIFT-1054) explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail

Posted by "Chris Morgan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Morgan updated THRIFT-1054:
---------------------------------

    Attachment: configure_ac_pkg_config_check.patch

Patch fixes pkg-config issues detecting mono (and possibly other cases where pkg-config was used).

> explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1054
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1054
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Kubuntu 10.10 (Maverick)
>            Reporter: Chris Morgan
>         Attachments: configure_ac_pkg_config_check.patch
>
>
> From aclocal.m4:
> # Note that if there is a possibility the first call to
> # PKG_CHECK_MODULES might not happen, you should be sure to include an
> # explicit call to PKG_PROG_PKG_CONFIG in your configure.ac
> I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call is missed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it.
> The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (THRIFT-1054) explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992035#comment-12992035 ] 

Bryan Duxbury commented on THRIFT-1054:
---------------------------------------

Everything still seems to work OK for me after applying, so I'm thinking I'll commit the patch. Any objections?

> explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1054
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1054
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Kubuntu 10.10 (Maverick)
>            Reporter: Chris Morgan
>            Assignee: Bryan Duxbury
>         Attachments: configure_ac_pkg_config_check.patch
>
>
> From aclocal.m4:
> {code}
> # Note that if there is a possibility the first call to
> # PKG_CHECK_MODULES might not happen, you should be sure to include an
> # explicit call to PKG_PROG_PKG_CONFIG in your configure.ac
> {code}
> I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call isn't always executed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it. aclocal.m4 warns against this situation and proposes calling PKG_PROG_PKG_CONFIG.
> The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (THRIFT-1054) explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail

Posted by "Chris Morgan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Morgan updated THRIFT-1054:
---------------------------------

    Patch Info: [Patch Available]

> explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1054
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1054
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Kubuntu 10.10 (Maverick)
>            Reporter: Chris Morgan
>            Assignee: Bryan Duxbury
>         Attachments: configure_ac_pkg_config_check.patch
>
>
> From aclocal.m4:
> # Note that if there is a possibility the first call to
> # PKG_CHECK_MODULES might not happen, you should be sure to include an
> # explicit call to PKG_PROG_PKG_CONFIG in your configure.ac
> I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call is missed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it.
> The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (THRIFT-1054) explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail

Posted by "Chris Morgan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Morgan updated THRIFT-1054:
---------------------------------

    Description: 
>From aclocal.m4:

# Note that if there is a possibility the first call to
# PKG_CHECK_MODULES might not happen, you should be sure to include an
# explicit call to PKG_PROG_PKG_CONFIG in your configure.ac

I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call isn't always executed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it. aclocal.m4 warns against this situation and proposes calling PKG_PROG_PKG_CONFIG.

The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac

  was:
>From aclocal.m4:

# Note that if there is a possibility the first call to
# PKG_CHECK_MODULES might not happen, you should be sure to include an
# explicit call to PKG_PROG_PKG_CONFIG in your configure.ac

I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call is missed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it.

The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac


> explicit call to PKG_PROG_PKG_CONFIG is missing and first use of PKG_CHECK_MODULES may not happen, causes mono detection to fail
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1054
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1054
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.7
>         Environment: Kubuntu 10.10 (Maverick)
>            Reporter: Chris Morgan
>            Assignee: Bryan Duxbury
>         Attachments: configure_ac_pkg_config_check.patch
>
>
> From aclocal.m4:
> # Note that if there is a possibility the first call to
> # PKG_CHECK_MODULES might not happen, you should be sure to include an
> # explicit call to PKG_PROG_PKG_CONFIG in your configure.ac
> I believe the first call to PKG_CHECK_MODULE is the only one that is expanded by m4 into the detection and setup of the pkg-config variables. Because this call isn't always executed, future calls to PKG_CHECK_MODULE attempt to use pkg-config and can't find it. aclocal.m4 warns against this situation and proposes calling PKG_PROG_PKG_CONFIG.
> The fix looks like an explicit PKG_PROG_PKG_CONFIG should be added to configure.ac

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira