[jira] [Commented] (HIVE-7571) RecordUpdater should read virtual columns from row

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102668#comment-14102668 ] 

Hive QA commented on HIVE-7571:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12662789/HIVE-7571.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 5819 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_8
org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/403/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/403/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-403/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12662789

> RecordUpdater should read virtual columns from row
> --------------------------------------------------
>
>                 Key: HIVE-7571
>                 URL: https://issues.apache.org/jira/browse/HIVE-7571
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Transactions
>    Affects Versions: 0.13.0
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>         Attachments: HIVE-7571.WIP.patch, HIVE-7571.patch
>
>
> Currently RecordUpdater.update and delete take rowid and original transaction as parameters.  These values are already present in the row as part of the new ROW__ID virtual column in HIVE-7513, and thus can be read by the writer from there.  And the writer will already have to handle skipping ROW__ID when writing, so it needs to be aware of that column anyone.
> We could instead read the values from ROW__ID and then remove it from the object inspector in FileSinkOperator, but this will be hard in the vectorization case where rows are being dealt with 10k at a time.
> For these reasons it makes more sense to do this work in the writer.



--
This message was sent by Atlassian JIRA
(v6.2#6252)